Skip to content

fix: align non-DCI icon visual size with DCI icons in fullscreen launcher #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhduiy wants to merge 1 commit into from
Closed

fix: align non-DCI icon visual size with DCI icons in fullscreen launcher #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion qml/IconItemDelegate.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,18 @@ Control {
Component {
id: imageComponent

// Non-DCI icons (file:/// URLs from absolute paths) lack the
// built-in padding that DCI format provides, causing them to
// appear visually larger than DCI icons at the same sourceSize.
// Apply a conservative scale factor to compensate.
readonly property real nonDciScaleFactor: 0.85

DciIcon {
objectName: "appIcon"
anchors.fill: parent
name: iconSource
sourceSize: Qt.size(root.maxIconSize, root.maxIconSize)
scale: (iconContainer.width / root.maxIconSize) * root.iconScaleFactor
scale: (iconContainer.width / root.maxIconSize) * root.iconScaleFactor * (iconSource.startsWith("file:///") ? imageComponent.nonDciScaleFactor : 1.0)
palette: DTK.makeIconPalette(root.palette)
theme: ApplicationHelper.DarkType
fillMode: Image.PreserveAspectFit
Expand Down
Loading