fix: use setter for short idle state initialization

[wjyrich]

1. Replace direct assignment of m_shortIdleState with setShortIdleState() call in initPowerSavingDConfig()
2. Ensure proper state management and any side effects handled by the setter are triggered during configuration initialization
3. Prevent potential inconsistency where the short idle state is set without invoking the proper setter logic

Log: Fixed short idle state not being properly initialized when loading power saving configuration

Influence:

1. Test power saving configuration initialization with short idle enabled and disabled
2. Verify short idle state behaves correctly after configuration changes
3. Test toggling short idle state through DConfig and verify the setter side effects are triggered
4. Verify no regression in other power saving configuration options (idle state, screen state)
5. Test system behavior when short idle is enabled/disabled during runtime configuration reload

fix: 使用 setter 初始化短空闲状态

1. 在 initPowerSavingDConfig() 中将 m_shortIdleState 的直接赋值替换为 setShortIdleState() 调用
2. 确保配置初始化期间能够正确触发 setter 中的状态管理和副作用处理
3. 防止短空闲状态在未调用正确 setter 逻辑的情况下被设置而导致潜在的不 一致

Log: 修复加载省电配置时短空闲状态未正确初始化的问题

Influence:

1. 测试短空闲启用和禁用时的省电配置初始化
2. 验证配置变更后短空闲状态的行为是否正确
3. 测试通过 DConfig 切换短空闲状态，验证 setter 的副作用是否被触发
4. 验证其他省电配置项（空闲状态、屏幕状态）无回归问题
5. 测试运行时配置重新加载时短空闲启用/禁用的系统行为

PMS: BUG-376709

Summary by Sourcery

Bug Fixes:

• Ensure the short idle power-saving state is initialized through its setter so required state management and side effects occur when loading configuration.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Power-saving configuration initialization now uses the short-idle state setter, ensuring consistent state management and triggering any associated side effects when configurations are loaded or reloaded.

Sequence diagram for short-idle configuration initialization

sequenceDiagram
    participant DConfig
    participant SystemPowerManager
    participant ShortIdleState
    DConfig->>SystemPowerManager: initPowerSavingDConfig()
    SystemPowerManager->>SystemPowerManager: setShortIdleState(value.toBool())
    SystemPowerManager->>ShortIdleState: Apply state management and side effects
    ShortIdleState-->>SystemPowerManager: State updated

Loading

Flow diagram for short-idle configuration reload

flowchart TD
    A[Load power-saving configuration] --> B{short idle state key}
    B -->|present| C["setShortIdleState(value.toBool())"]
    C --> D[State and side effects remain consistent]
    B -->|absent| E[Continue loading other power-saving options]

Loading

File-Level Changes

Change	Details	Files
Initialize the short-idle state through its setter during power-saving DConfig loading.	Replace direct member assignment with setShortIdleState(). Ensure setter-managed state transitions and side effects run during initialization and configuration reloads.	src/plugin-qt/power/system/powermanager.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="src/plugin-qt/power/system/powermanager.cpp" line_range="554" />
<code_context>
             m_shortIdleEnabled = value.toBool();
         else if (key == QLatin1String(kShortIdleState))
-            m_shortIdleState = value.toBool();
+            setShortIdleState(value.toBool());
         else if (key == QLatin1String(kIdleStatePath))
             m_idleStatePath = value.toString();
</code_context>
<issue_to_address>
**issue (bug_risk):** `initPowerSavingDConfig()` loads `kShortIdleState` before `kShortIdleEnable`, but `setShortIdleState()` immediately returns while `m_shortIdleEnabled` is false. Consequently, a configuration with short idle enabled and state enabled leaves `m_shortIdleState` false after initialization; the later direct assignment of `m_shortIdleEnabled` does not retry the state.

**Triggers:** When the configured short-idle state is true and the short-idle feature is enabled.

**Suggested fix:** Load `kShortIdleEnable` before `kShortIdleState`, or defer applying the state until the enable flag has been initialized; apply the same ordering/deferral for runtime configuration updates.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, wjyrich

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wjyrich]

/forcemerge

[deepin-bot]

This pr force merged! (status: blocked)