Revert "fix(dock): prevent dock from taking focus"

[mhduiy]

This reverts commit d390097.

pms: TASK-394609

Summary by Sourcery

Enhancements:

• Restore on-demand keyboard interaction for the dock so it can receive focus when needed.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reverts a previous change that prevented the dock window from accepting keyboard focus, restoring on-demand keyboard interactivity for the dock’s layer-shell window.

State diagram for dock keyboard interactivity behavior

stateDiagram-v2
    [*] --> KeyboardInteractivityOnDemand

    state KeyboardInteractivityOnDemand {
        [*] --> DockCanTakeFocus
        DockCanTakeFocus --> DockUsesKeyboardInput: user_interacts_with_dock
        DockUsesKeyboardInput --> DockCanTakeFocus: keyboard_focus_lost
    }

    note "Configured via DLayerShellWindow.keyboardInteractivity = DLayerShellWindow.KeyboardInteractivityOnDemand in main.qml" as N1
    KeyboardInteractivityOnDemand --> N1

Loading

File-Level Changes

Change	Details	Files
Restore on-demand keyboard interactivity for the dock window, effectively reverting a prior focus-prevention change.	Change DLayerShellWindow.keyboardInteractivity from KeyboardInteractivityNone back to KeyboardInteractivityOnDemand Allow the dock layer-shell window to receive keyboard focus when needed instead of never accepting focus	panels/dock/package/main.qml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider whether DLayerShellWindow.keyboardInteractivity should depend on the dock's visibility or mode (e.g., Panel.hideMode) instead of always using KeyboardInteractivityOnDemand, to avoid unintended focus behavior in specific configurations.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider whether `DLayerShellWindow.keyboardInteractivity` should depend on the dock's visibility or mode (e.g., `Panel.hideMode`) instead of always using `KeyboardInteractivityOnDemand`, to avoid unintended focus behavior in specific configurations.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-bot]

TAG Bot

New tag: 2.0.54
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1733

[deepin-bot]

TAG Bot

New tag: 2.0.55
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1752

[deepin-bot]

TAG Bot

New tag: 2.0.56
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1753