Conversation
Enable the same warning flags as dpkg-buildpackage for C and C++ targets so that a plain `cmake -Bbuild && cmake --build build` reports the same warnings/errors as the package build. debian/rules already appends -Wall (DEB_CXXFLAGS_MAINT_APPEND) and hardening=+all adds -Wformat -Werror=format-security; mirror those locally alongside the existing -Werror so warnings that would only fail the dpkg build are caught during local development. Log: align local cmake compile flags with dpkg-buildpackage PMS: TASK-394335
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Ivy233 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideCMake now applies the Debian-aligned -Wall, -Wformat, and -Werror=format-security flags to C and C++ targets, ensuring local builds surface the same format-related warnings and errors as dpkg-buildpackage. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： [] 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： ['微小建议：4 行 add_compile_options 可合并为单次调用以减少重复，但当前方式可读性良好且与现有代码风格一致，非必须修改'] 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： [] 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： ['本次新增的 -Wformat 和 -Werror=format-security 标志实际上增强了代码安全性，可在编译阶段捕获格式字符串漏洞'] 💡 改进建议代码示例// 暂无代码示例本报告由 AI 代码审查工具自动生成 |
BLumia
reviewed
Sep 9, 2026
Ivy233
marked this pull request as draft
September 9, 2026 07:56
|
TAG Bot New tag: 2.0.54 |
|
TAG Bot New tag: 2.0.55 |
|
TAG Bot New tag: 2.0.56 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable the same warning flags as dpkg-buildpackage for C and C++ targets so that a plain
cmake -Bbuild && cmake --build buildreports the same warnings/errors as the package build. debian/rules already appends -Wall (DEB_CXXFLAGS_MAINT_APPEND) and hardening=+all adds -Wformat -Werror=format-security; mirror those locally alongside the existing -Werror so warnings that would only fail the dpkg build are caught during local development.Log: align local cmake compile flags with dpkg-buildpackage
PMS: TASK-394335
Summary by Sourcery
Align local CMake compiler checks with dpkg-buildpackage to catch packaging-build warnings during development.
Enhancements:
Build: