Skip to content

fix: prevent context menu/popup from toggling closed on rapid right-click (BUG-353435) #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhduiy wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −2
Open

fix: prevent context menu/popup from toggling closed on rapid right-click (BUG-353435) #1740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion frame/qml/PanelMenu.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,14 @@ Item {

function open()
{
// Keep open() pure-open semantics: when already visible, do nothing
// instead of toggling closed. The redundant toggle-close here caused
// BUG-353435: during the async window between open() setting
// menu.visible=true and finalizeOpen() calling grabMouse(), a second
// right-click could reach PluginItem, trigger another open(), and hit
// this branch, closing the menu. Left-click toggle is already handled
// in the C++ layer (itemPopupApplet). See PanelPopup.open() too.
if (menu.visible) {
close()
return
}

Expand Down
8 changes: 7 additions & 1 deletion frame/qml/PanelPopup.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,14 @@ Item {

function open()
{
// Keep open() pure-open semantics: when already visible, do nothing
// instead of toggling closed. The redundant toggle-close here caused
// BUG-353435: during the async window between open() setting
// popup.visible=true and finalizeOpen() showing the window, a second
// right-click could reach PluginItem, trigger another open(), and hit
// this branch, closing the popup. Left-click toggle is already handled
// in the C++ layer (itemPopupApplet). See PanelMenu.open() too.
if (popup.visible) {
close()
return
}

Expand Down
Loading