Skip to content

fix(dock): keep dock shown when fullscreen window minimized - #1745

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
glyvut:master
Sep 23, 2026
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
glyvut:master

Conversation

@glyvut

@glyvut glyvut commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Ignore minimized windows when aggregating fullscreen state on Wayland so the dock is not hidden by a minimized fullscreen window.

Wayland下聚合全屏状态时忽略已最小化的窗口,避免全屏窗口最小化后任务栏仍被隐藏。

Log: 修复全屏窗口最小化后任务栏仍隐藏的问题
PMS: BUG-376727
Influence: Wayland/Treeland环境下全屏窗口最小化后任务栏恢复显示,其他显示模式不受影响。

Summary by Sourcery

Bug Fixes:

  • Prevent minimized fullscreen windows from keeping the dock hidden on Wayland.

@sourcery-ai

sourcery-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Wayland fullscreen-state aggregation to ignore minimized fullscreen windows, allowing the dock to reappear after such a window is minimized without affecting other display modes.

Sequence diagram for Wayland dock visibility after minimizing a fullscreen window

sequenceDiagram
    participant Window as WaylandWindow
    participant Monitor as TreeLandWindowMonitor
    participant Dock
    Window->>Monitor: isFullscreen()
    Monitor->>Window: isMinimized()
    alt fullscreen and not minimized
        Monitor->>Monitor: updateFullscreenState()
        Monitor-->>Dock: windowFullscreenChanged(true)
        Dock->>Dock: hide()
    else minimized fullscreen window
        Monitor->>Monitor: updateFullscreenState()
        Monitor-->>Dock: windowFullscreenChanged(false)
        Dock->>Dock: show()
    end
Loading

File-Level Changes

Change Details Files
Exclude minimized fullscreen windows when aggregating fullscreen state on Wayland.
  • Require fullscreen windows to also be non-minimized before hiding the dock or emitting fullscreen-state changes.
  • Preserve existing behavior for non-Wayland display modes and non-minimized fullscreen windows.
panels/dock/taskmanager/treelandwindowmonitor.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glyvut, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot

deepin-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 2.0.55
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1752

Ignore minimized windows when aggregating fullscreen state on
Wayland so the dock is not hidden by a minimized fullscreen window.

Wayland下聚合全屏状态时忽略已最小化的窗口,避免全屏窗口最小化后任务栏仍被隐藏。

Log: 修复全屏窗口最小化后任务栏仍隐藏的问题
PMS: BUG-376727
Influence: Wayland/Treeland环境下全屏窗口最小化后任务栏恢复显示,其他显示模式不受影响。
@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 98 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 代码变更简洁正确,修复了全屏窗口最小化后任务栏仍隐藏的问题,未发现安全漏洞,建议添加行内注释说明排除最小化窗口的原因。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: ['建议在新增条件处添加行内注释,说明为何排除最小化窗口']


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: []


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: []


💡 改进建议代码示例

// 暂无代码示例

本报告由 AI 代码审查工具自动生成

@mhduiy

mhduiy commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot

deepin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

This pr force merged! (status: blocked)

@deepin-bot
deepin-bot Bot merged commit e5e529b into linuxdeepin:master Sep 23, 2026
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants