fix(dock): keep dock shown when fullscreen window minimized - #1745
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates Wayland fullscreen-state aggregation to ignore minimized fullscreen windows, allowing the dock to reappear after such a window is minimized without affecting other display modes. Sequence diagram for Wayland dock visibility after minimizing a fullscreen windowsequenceDiagram
participant Window as WaylandWindow
participant Monitor as TreeLandWindowMonitor
participant Dock
Window->>Monitor: isFullscreen()
Monitor->>Window: isMinimized()
alt fullscreen and not minimized
Monitor->>Monitor: updateFullscreenState()
Monitor-->>Dock: windowFullscreenChanged(true)
Dock->>Dock: hide()
else minimized fullscreen window
Monitor->>Monitor: updateFullscreenState()
Monitor-->>Dock: windowFullscreenChanged(false)
Dock->>Dock: show()
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: glyvut, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 2.0.55 |
Ignore minimized windows when aggregating fullscreen state on Wayland so the dock is not hidden by a minimized fullscreen window. Wayland下聚合全屏状态时忽略已最小化的窗口,避免全屏窗口最小化后任务栏仍被隐藏。 Log: 修复全屏窗口最小化后任务栏仍隐藏的问题 PMS: BUG-376727 Influence: Wayland/Treeland环境下全屏窗口最小化后任务栏恢复显示,其他显示模式不受影响。
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: ['建议在新增条件处添加行内注释,说明为何排除最小化窗口'] 3. 代码性能 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 优秀 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例// 暂无代码示例本报告由 AI 代码审查工具自动生成 |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Ignore minimized windows when aggregating fullscreen state on Wayland so the dock is not hidden by a minimized fullscreen window.
Wayland下聚合全屏状态时忽略已最小化的窗口,避免全屏窗口最小化后任务栏仍被隐藏。
Log: 修复全屏窗口最小化后任务栏仍隐藏的问题
PMS: BUG-376727
Influence: Wayland/Treeland环境下全屏窗口最小化后任务栏恢复显示,其他显示模式不受影响。
Summary by Sourcery
Bug Fixes: