Skip to content

fix: adjust applet icon smoothing on rotation #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Sep 20, 2026
Merged

fix: adjust applet icon smoothing on rotation #1747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion panels/dock/AppletItemButton.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ IconButton {
}

Component.onCompleted: {
contentItem.smooth = false
contentItem.smooth = Qt.binding(function () {
return Math.round(contentItem.rotation) % 90 !== 0

@sourcery-ai sourcery-ai Bot Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): The binding disables smoothing for every rotation within 0.5 degrees of a multiple of 90, not only for exact 0, 90, 180, or 270 degree orientations. For example, rotations of 89.6° and 90.4° round to 90 and render without smoothing despite being arbitrary non-90-degree angles.

Triggers: When an icon is rotated to an angle close to, but not exactly equal to, a multiple of 90 degrees.

Suggested fix: Test the rotation remainder directly, optionally with a small floating-point epsilon, instead of rounding the rotation to an integer degree.

Suggested change
return Math.round(contentItem.rotation) % 90 !== 0
return contentItem.rotation % 90 !== 0

})
}
}
Loading