fix: set textFormat to PlainText for notification title - #1749
deepin-bot[bot] merged 1 commit into
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a single QML property to prevent HTML-like notification titles from being rendered as styled links, while preserving link support in notification bodies and covering all views that reuse NotifyItemContent. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
这pr里不应该有两个提交， |
The notification title Text element in NotifyItemContent.qml did not set textFormat, so Qt defaulted to Text.AutoText which detects and renders HTML tags. When a notification summary contains HTML <a> tags, the title was rendered as a blue underlined link instead of plain text. Add textFormat: Text.PlainText to the title Text to ensure the title is always rendered as plain text, preventing HTML tag rendering. Log: fix notification title showing link style with HTML tags Bug: https://pms.uniontech.com/bug-view-377829.html Change-Id: IF3B5F7F293B005B5
0e50b87 to
3ef3361
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, robertkill The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerege |
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 语法正确，无需修改。textFormat: Text.PlainText 是有效的 QML 属性赋值，正确放置在 Text 元素的属性块中（第262-278行），与现有属性 text、visible、maximumLineCount、font、color、renderType、wrapMode、elide 等并列。 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 建议在 textFormat: Text.PlainText 上方添加简短注释，例如 // 使用 PlainText 防止标题中的 HTML 标记被渲染为链接样式，与 body Text 元素的注释风格保持一致，提高可维护性。 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好。设置 textFormat 为 Text.PlainText 实际上提升了性能，因为 Qt 不再需要执行 AutoText 模式的 HTML 自动检测和解析，直接以纯文本模式渲染，减少了不必要的处理开销。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 本次变更提升了安全性。通过将标题文本格式限制为 PlainText，防止了通知标题中潜在的 HTML 标记注入风险（如 标签、 💡 改进建议代码示例// 标题 Text 元素：使用 PlainText 防止 HTML 标记渲染
Text {
text: root.title
visible: text !== ""
maximumLineCount: 1
textFormat: Text.PlainText // 确保标题始终以纯文本形式渲染
font {
pixelSize: DTK.fontManager.t8.pixelSize
family: DTK.fontManager.t8.family
bold: true
}
color: palette.windowText
renderType: Text.QtRendering
wrapMode: Text.NoWrap
elide: Text.ElideRight
Layout.fillWidth: true
Layout.alignment: Qt.AlignLeft | Qt.AlignTop
}本报告由 AI 代码审查工具自动生成 |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
3 participants
Root Cause Analysis
The notification title
Textelement inNotifyItemContent.qmldid not settextFormat, so Qt defaulted toText.AutoTextmode, which automatically detects and renders HTML tags. When a notification summary contains HTML<a>tags, the title was rendered as a blue underlined link instead of plain text.Key evidence:
NotifyItemContent.qml:262— titleTextelement has notextFormatsetNotifyItemContent.qml:284-307— bodyTextelement deliberately supports links (linkColor,onLinkActivated,HoverHandler), confirming the title's lack oftextFormatis an omissionFix
Add
textFormat: Text.PlainTextto the titleTextelement inNotifyItemContent.qml, ensuring the title is always rendered as plain text without HTML parsing.Change Safety Assessment
Code Safety: Low risk. Only one QML property added (
textFormat: Text.PlainText), no existing logic modified, no function signatures changed, no new dependencies introduced.Business Impact: Notification titles (in banners and notification center) will no longer render HTML tags as link styles — they will display as plain text. Notification body text still supports links as designed. All notification views (Bubble, NormalNotify, OverlapNotify) share the
NotifyItemContentcomponent, so this one-line fix covers all scenarios.Regression Testing: Send a notification with
notify-send '<a href="https://example.com">test</a> title' "body"and verify the title displays as plain text without blue/underline styling.根因分析
通知标题
Text元素未设置textFormat，Qt 默认使用Text.AutoText模式，自动检测并渲染 HTML 标记。当通知标题包含 HTML<a>标签时，标题被渲染为蓝色下划线链接样式，而非纯文本。关键证据：
NotifyItemContent.qml:262— 标题Text元素未设置textFormatNotifyItemContent.qml:284-307— 正文Text元素刻意支持链接（linkColor、onLinkActivated、HoverHandler），佐证标题缺少textFormat是遗漏修复方案
在
NotifyItemContent.qml的标题Text元素中添加textFormat: Text.PlainText，使标题始终以纯文本形式渲染，不解析 HTML 标记。改动安全评估
代码安全：低风险。仅新增一个 QML 属性（
textFormat: Text.PlainText），不修改任何已有逻辑，不改变函数签名，不引入新依赖。业务影响范围：通知标题（横幅和通知中心）将不再将 HTML 标记渲染为链接样式，改为纯文本展示。通知正文仍保留链接支持。所有通知视图（Bubble、NormalNotify、OverlapNotify）共用
NotifyItemContent组件，一处修复覆盖全部场景。验证建议：使用
notify-send '<a href="https://example.com">test</a> title' "body"发送通知，验证标题以纯文本展示，无蓝色/下划线样式。Summary by Sourcery
Bug Fixes: