fix(a11y): fix Accessible.id crash and compile warning - #1751
Conversation
There was a problem hiding this comment.
Sorry @MyLeeJiEun, you've used your own review budget of 250,000 diff characters for the last 7 days.
You can request another review in 3 hours and 58 minutes by commenting @sourcery-ai review. Upgrade to get a review now.
Reviewer's GuideThe PR works around a Qt 6.8 QML startup crash by moving Accessible.id initialization from load-time bindings to Component.onCompleted handlers throughout dock and notification UI components, while preserving existing completion logic and changing WindowManager::m_ActiveId to uint to remove a compile warning. Sequence diagram for deferred accessibility initializationsequenceDiagram
participant QML as QML component loader
participant Component as UI component
participant Accessible as Accessible attached property
QML->>Component: Create component
Component->>Accessible: Component.onCompleted
Component->>Accessible: Assign Accessible.id
Accessible-->>Component: Accessibility identifier available
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ecf2192 to
5e67eea
Compare
5e67eea to
d56e55b
Compare
1. Replace static Accessible.id bindings with Component.onCompleted assignments across dock, tray and notification panels, since Qt 6.8's revision-gated property fails at load time and crashes applet creation. 2. Merge the new onCompleted handlers into existing ones where an object already defined Component.onCompleted, avoiding duplicate-handler errors. 3. Change WindowManager::m_ActiveId from int to uint to silence the signed/unsigned comparison warning. Log: Replace Accessible.id bindings with Component.onCompleted to fix the Qt 6.8 load-time crash, and fix a WindowManager compile warning. Influence: Fixes dde-shell startup crash and a compile warning. fix(a11y): 修复 Accessible.id 崩溃和编译警告 1. 将 dock、tray、notification 各面板中静态的 Accessible.id 绑定改为 Component.onCompleted 命令式赋值,规避 Qt 6.8 下版本门控属性加载失败导致的崩溃。 2. 对已存在 Component.onCompleted 的对象进行合并,避免同一对象出现重复处理器错误。 3. 将 WindowManager::m_ActiveId 由 int 改为 uint,消除有符号/无符号比较编译警告。 Log: 用 Component.onCompleted 替代 Accessible.id 绑定以修复 Qt 6.8 加载期崩溃,并修复 WindowManager 编译警告。 PMS: TASK-395933 Influence: 修复 dde-shell 启动崩溃和编译警告。
d56e55b to
8d97efc
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Log: Replace Accessible.id bindings with Component.onCompleted to fix the Qt 6.8 load-time crash, and fix a WindowManager compile warning.
Influence: Fixes dde-shell startup crash and a compile warning.
fix(a11y): 修复 Accessible.id 崩溃和编译警告
Log: 用 Component.onCompleted 替代 Accessible.id 绑定以修复 Qt 6.8 加载期崩溃,并修复 WindowManager 编译警告。
PMS: TASK-395933
Influence: 修复 dde-shell 启动崩溃和编译警告。
Summary by Sourcery
Prevent accessibility-related startup crashes and resolve the WindowManager compilation warning.
Bug Fixes:
Enhancements: