Skip to content

chore(i18n): remove redundant ar_EG translations, keep ar - #516

Merged
BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:chore/remove-ar_EG-translations
Sep 20, 2026
Merged

BLumia merged 1 commit into
linuxdeepin:masterfrom
BLumia:chore/remove-ar_EG-translations

Conversation

@BLumia

@BLumia BLumia commented Sep 18, 2026 •

Copy link
Copy Markdown
Member

The ar_EG (Egyptian Arabic) translation files are redundant variants of the existing ar (Arabic) translations. All build systems use glob patterns to collect .ts files, so removing these files has no impact on the build. The corresponding *_ar.ts files remain in place.

Files removed:

  • plugins/dde-dock/translations/dde-dock_ar_EG.ts
  • plugins/dde-network-display-ui/plugins/dock-wirelesscasting-plugin/translations/dock-wirelesscasting-plugin_ar_EG.ts

See: DDE-333

Summary by Sourcery

Enhancements:

  • Remove redundant Egyptian Arabic translation files while retaining the shared Arabic translations.

@sourcery-ai

sourcery-ai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This cleanup removes two redundant ar_EG translation files; because translation discovery uses .ts globs and the canonical Arabic files remain, build and Arabic localization behavior should be unchanged.

File-Level Changes

Change Details Files
Remove redundant Egyptian Arabic translation catalogs while retaining the canonical Arabic catalogs.
  • Delete the dock plugin’s ar_EG translation file.
  • Delete the wireless casting plugin’s ar_EG translation file.
  • Preserve the corresponding *_ar.ts files for Arabic localization.
plugins/dde-dock/translations/dde-dock_ar_EG.ts
plugins/dde-network-display-ui/plugins/dock-wirelesscasting-plugin/translations/dock-wirelesscasting-plugin_ar_EG.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, fly602

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 100 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 总体评分 100 分,大于 70 分通过阈值,代码质量符合要求。本次 PR 仅删除冗余的 ar_EG 翻译文件,无新增代码,无安全风险。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 本次 PR 为纯文件删除操作,无语法逻辑变更,无编译错误风险。构建系统使用 glob 模式收集 .ts 文件,删除冗余翻译文件不影响构建。


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 删除冗余的 ar_EG 翻译变体文件是良好的代码维护实践,减少了重复资源,保持了翻译文件的整洁性。PR 描述清晰,说明了删除原因和影响。


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 删除冗余文件减少了仓库体积和构建系统需要处理的翻译文件数量,对性能有轻微正面影响。


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 本次 PR 仅删除翻译资源文件,未引入任何新代码,不存在安全风险。被删除的文件内容仅为 Qt 翻译 XML 条目,不含敏感信息。


💡 改进建议代码示例

// 本次 PR 为纯文件删除操作,删除冗余的 ar_EG 翻译文件,无需改进代码示例
// 对应的 *_ar.ts 翻译文件已保留,不影响阿拉伯语本地化支持

本报告由 AI 代码审查工具自动生成

@BLumia
BLumia merged commit 4fa6ef2 into linuxdeepin:master Sep 20, 2026
8 of 10 checks passed
@BLumia
BLumia deleted the chore/remove-ar_EG-translations branch September 20, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants