refactor: remove daemon and searcher projects for index merge - #261
Conversation
Remove the daemon and searcher subprojects in preparation for the upcoming index service consolidation. Shared mount_info and utils files are moved into server. Unused config files and the daemon stress test are also dropped. 移除 daemon 和 searcher 子项目,为后续索引服务合并做准备。 将共享的 mount_info 与工具文件迁移至 server 目录下,同时删除 未使用的配置文件和 daemon 压测脚本。 Log: 移除 daemon 和 searcher 项目 PMS: TASK-395961 Influence: 不再构建 deepin-anything-daemon 与 deepin-anything-searcher 可执行文件;server 保持原有功能不变,构建依赖相应减少。
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR removes the daemon and searcher projects and their build/package/test artifacts, then consolidates the shared mount-info and utility code under server with updated CMake and include paths so the server remains buildable without the retired subprojects. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/CMakeLists.txt" line_range="19-22" />
<code_context>
add_compile_options(-Wall -Wextra -pedantic -Werror)
-add_subdirectory("daemon")
add_subdirectory("server")
add_subdirectory("kernelmod")
-add_subdirectory("searcher")
add_subdirectory("logger")
add_subdirectory("dispatcher")
</code_context>
<issue_to_address>
**nitpick:** AGENTS.md still documents `src/daemon/` and `src/searcher/` as active subprojects even though these directories are no longer added to the build and their source trees were deleted, so contributor guidance points to nonexistent projects.
**Suggested fix:** Update AGENTS.md to remove the deleted daemon and searcher project descriptions and revise the repository layout.
</issue_to_address>
deepin pr auto reviewAI 代码审查报告
总体评分
总体评价本次 PR 为重构操作,移除了 daemon 和 searcher 子项目以进行索引合并。变更内容包括:删除 漏洞统计
漏洞对比统计:新增漏洞 0 个,减少漏洞 0 个,持平 0 个 维度1:语法逻辑(25/25)✓
审查内容:
结论:无编译错误,逻辑合理,边界处理完善 维度2:代码质量(25/25)✓
审查内容:
结论:删除操作完整、一致,无遗留问题 维度3:代码性能(20/20)✓
审查内容:
结论:无性能瓶颈,移除冗余组件有助于整体性能提升 维度4:代码安全(30/30)✓
审查内容:
结论:无安全风险,安全合规 审查结论本次 PR 是一个干净的重构操作,目的是移除 daemon 和 searcher 子项目以进行索引合并。所有变更均为删除操作和对应的构建配置更新,修改一致性良好,无遗留引用,无安全漏洞。建议合并。 本报告由 AI 代码审查系统自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
7bb0e53
into
linuxdeepin:develop/snipe-20260923
Remove the daemon and searcher subprojects in preparation for the upcoming index service consolidation. Shared mount_info and utils files are moved into server. Unused config files and the daemon stress test are also dropped.
移除 daemon 和 searcher 子项目,为后续索引服务合并做准备。
将共享的 mount_info 与工具文件迁移至 server 目录下,同时删除
未使用的配置文件和 daemon 压测脚本。
Log: 移除 daemon 和 searcher 项目
PMS: TASK-395961
Influence: 不再构建 deepin-anything-daemon 与 deepin-anything-searcher 可执行文件;server 保持原有功能不变,构建依赖相应减少。
Summary by Sourcery
Consolidate the index-related codebase by removing the daemon and searcher projects and retaining their shared server utilities in the server component.
Enhancements:
Build:
Tests: