Skip to content

feat: remove Arch Linux and RPM packaging files - #262

Merged
Johnson-zs merged 1 commit into
linuxdeepin:develop/snipe-20260923from
Johnson-zs:develop/snipe-20260923
Sep 28, 2026
Merged

Johnson-zs merged 1 commit into
linuxdeepin:develop/snipe-20260923from
Johnson-zs:develop/snipe-20260923

Conversation

@Johnson-zs

@Johnson-zs Johnson-zs commented Sep 28, 2026 •

Copy link
Copy Markdown

Removed Arch Linux PKGBUILD and related systemd sysusers configuration file as part of cleanup. These files were specific to building and packaging deepin-anything for Arch Linux distribution.

Deleted multiple documentation files including app_developer.md, design_considerations.md, end_user_tester.md, and lib_developer.md. These documents contained outdated development guides, design documentation, and testing instructions that are no longer relevant to the current codebase.

Removed RPM specification file for building packages on RPM-based distributions like Fedora, RHEL, and openSUSE. The .spec file included build requirements, installation instructions, and package structure definitions.

These changes reflect a cleanup of distribution-specific packaging files and outdated documentation that was not being maintained. The removed files were likely remnants from when the project supported multiple Linux distributions or earlier development phases.

Log: Removed outdated distribution packaging files and documentation

Influence:

  1. No impact on core functionality or library usage
  2. Arch Linux users will no longer find PKGBUILD for building from source
  3. RPM-based distribution users will need alternative packaging methods
  4. Developers should refer to current documentation sources for API usage
  5. The library functionality remains unchanged

feat: 移除 Arch Linux 和 RPM 打包文件

移除 Arch Linux 的 PKGBUILD 和相关 systemd sysusers 配置文件作为清理 工作的一部分。这些文件专门用于在 Arch Linux 发行版上构建和打包 deepin-
anything。

删除多个文档文件,包括 app_developer.md、design_considerations.md、 end_user_tester.md 和 lib_developer.md。这些文档包含过时的开发指南、设计 文档和测试说明,与当前代码库不再相关。

移除用于在基于 RPM 的发行版(如 Fedora、RHEL 和 openSUSE)上构建包的 RPM 规范文件。.spec 文件包含构建要求、安装说明和包结构定义。

这些更改反映了对发行版特定打包文件和未维护的过时文档的清理。被移除的文件
可能是项目支持多个 Linux 发行版或早期开发阶段遗留下来的。

Log: 移除过时的发行版打包文件和文档

Influence:

  1. 不影响核心功能或库使用
  2. Arch Linux 用户将无法找到用于从源代码构建的 PKGBUILD
  3. 基于 RPM 的发行版用户需要替代的打包方法
  4. 开发人员应参考当前文档源了解 API 使用
  5. 库功能保持不变

Summary by Sourcery

Clean up obsolete distribution packaging assets and unmaintained documentation without changing core library functionality.

Enhancements:

  • Remove obsolete Arch Linux and RPM packaging metadata and build definitions.
  • Remove outdated developer, design, and testing documentation.

Chores:

  • Update REUSE licensing annotations to reflect the removed packaging and third-party files.

@sourcery-ai

sourcery-ai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This cleanup removes obsolete Arch Linux and RPM packaging metadata plus four outdated documentation guides. Core source functionality is unchanged, but Arch and RPM users lose the repository-provided packaging definitions and developers should use the current documentation sources instead.

File-Level Changes

Change Details Files
Remove distribution-specific packaging definitions for Arch Linux and RPM-based distributions.
  • Delete the Arch Linux PKGBUILD.
  • Delete the Arch Linux systemd sysusers configuration.
  • Delete the RPM package specification and its build/install metadata.
archlinux/PKGBUILD
archlinux/deepin-anything-server.sysusers
rpm/deepin-anything.spec
Remove outdated project documentation that is no longer maintained.
  • Delete legacy application developer, design, end-user testing, and library developer guides.
docs/app_developer.md
docs/design_considerations.md
docs/end_user_tester.md
docs/lib_developer.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
  • 检测到敏感词export变动
详情
    {
    "export": {
        "rpm/deepin-anything.spec": {
            "a": [
                "export PATH=$PATH:%{_libdir}/qt5/bin"
            ]
        }
    }
}

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

Removed Arch Linux PKGBUILD and related systemd sysusers configuration
file as part of cleanup. These files were specific to building and
packaging deepin-anything for Arch Linux distribution.

Deleted multiple documentation files including app_developer.md,
design_considerations.md, end_user_tester.md, and lib_developer.md.
These documents contained outdated development guides, design
documentation, and testing instructions that are no longer relevant to
the current codebase.

Removed RPM specification file for building packages on RPM-based
distributions like Fedora, RHEL, and openSUSE. The .spec file included
build requirements, installation instructions, and package structure
definitions.

These changes reflect a cleanup of distribution-specific packaging files
and outdated documentation that was not being maintained. The removed
files were likely remnants from when the project supported multiple
Linux distributions or earlier development phases.

Log: Removed outdated distribution packaging files and documentation

Influence:
1. No impact on core functionality or library usage
2. Arch Linux users will no longer find PKGBUILD for building from
source
3. RPM-based distribution users will need alternative packaging methods
4. Developers should refer to current documentation sources for API
usage
5. The library functionality remains unchanged

feat: 移除 Arch Linux 和 RPM 打包文件

移除 Arch Linux 的 PKGBUILD 和相关 systemd sysusers 配置文件作为清理
工作的一部分。这些文件专门用于在 Arch Linux 发行版上构建和打包 deepin-
anything。

删除多个文档文件,包括 app_developer.md、design_considerations.md、
end_user_tester.md 和 lib_developer.md。这些文档包含过时的开发指南、设计
文档和测试说明,与当前代码库不再相关。

移除用于在基于 RPM 的发行版(如 Fedora、RHEL 和 openSUSE)上构建包的 RPM
规范文件。.spec 文件包含构建要求、安装说明和包结构定义。

这些更改反映了对发行版特定打包文件和未维护的过时文档的清理。被移除的文件
可能是项目支持多个 Linux 发行版或早期开发阶段遗留下来的。

Log: 移除过时的发行版打包文件和文档

Influence:
1. 不影响核心功能或库使用
2. Arch Linux 用户将无法找到用于从源代码构建的 PKGBUILD
3. 基于 RPM 的发行版用户需要替代的打包方法
4. 开发人员应参考当前文档源了解 API 使用
5. 库功能保持不变
@Johnson-zs
Johnson-zs force-pushed the develop/snipe-20260923 branch from 67b29a5 to 9eb1e36 Compare September 28, 2026 00:49
@github-actions

Copy link
Copy Markdown
  • 检测到敏感词export变动
详情
    {
    "export": {
        "rpm/deepin-anything.spec": {
            "a": [
                "export PATH=$PATH:%{_libdir}/qt5/bin"
            ]
        }
    }
}

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 92 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 本次提交主要删除 Arch Linux 和 RPM 打包文件及相关文档,不涉及源代码变更,无安全漏洞。但 PR 标题与实际变更范围不完全匹配(删除了文档文件未在标题中说明),且 REUSE.toml 中移除了 3rdparty/fsearch 相关注解与声明目的不一致。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


2. 代码质量 ✅

评价: 良好 ✅ 通过

潜在问题:

  1. docs/design_considerations.md:1 - 删除了包含重要架构设计文档的文件(380行设计说明),可能影响项目可维护性
  2. docs/app_developer.md:1 - 删除了应用开发者文档(127行API使用说明),可能影响开发者使用
  3. docs/end_user_tester.md:1 - 删除了终端用户测试文档(43行测试说明),可能影响测试流程
  4. REUSE.toml:21 - 移除了 3rdparty/fsearch/thread_pool.c 和 thread_pool.h 的 SPDX 注解,此变更与 PR 声明的「移除 Arch Linux 和 RPM 打包文件」目的不相关
  5. PR Title:0 - PR 标题声明移除 Arch Linux 和 RPM 打包文件,但实际还删除了4个文档文件,标题未完全反映变更范围

建议: 1. 建议修改 PR 标题为更准确的描述,如「feat: remove Arch Linux, RPM packaging files and documentation」
2. 确认 3rdparty/fsearch 文件是否仍存在于仓库中,若存在则不应移除其 SPDX 许可证注解
3. 建议保留或迁移重要架构设计文档而非直接删除


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 无


💡 改进建议代码示例

// 暂无代码示例

本报告由 AI 代码审查工具自动生成

@Johnson-zs
Johnson-zs merged commit 46479d9 into linuxdeepin:develop/snipe-20260923 Sep 28, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants