Skip to content

fix(ui): normalize invalid available size to dash in size info widget - #221

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:release/1071from
GongHeng2017:202609091503-re-1071-fix
Sep 9, 2026
Merged

deepin-bot[bot] merged 1 commit into
linuxdeepin:release/1071from
GongHeng2017:202609091503-re-1071-fix

Conversation

@GongHeng2017

@GongHeng2017 GongHeng2017 commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

When m_availableSize contains a "-" (e.g. from negative value formatting), normalize it to "-" to avoid displaying invalid available space.

当可用空间值含"-"(如负值格式化结果)时,将其统一为"-",避免显示无效的可用空间值。

Log: 修复可用空间显示含"-"的异常值
PMS: BUG-204631
Influence: 修复后分区信息中可用空间显示为"-"而非负值,避免界面显示异常。

Summary by Sourcery

Bug Fixes:

  • Normalize invalid available-size values containing a dash to display as a single dash in the size information widget.

When m_availableSize contains a "-" (e.g. from negative value formatting),
normalize it to "-" to avoid displaying invalid available space.

当可用空间值含"-"(如负值格式化结果)时,将其统一为"-",避免显示无效的可用空间值。

Log: 修复可用空间显示含"-"的异常值
PMS: BUG-204631
Influence: 修复后分区信息中可用空间显示为"-"而非负值,避免界面显示异常。
@sourcery-ai

sourcery-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The size information widget now converts available-size values containing a hyphen into a standalone “-” before painting, ensuring invalid or negative formatted values are shown as unavailable space rather than displayed directly.

File-Level Changes

Change Details Files
Normalize invalid available-size text before rendering the size information widget.
  • Detect a hyphen anywhere in the available-size string.
  • Replace the value with a standalone dash to prevent negative or otherwise invalid space values from being displayed.
application/widgets/customcontrol/sizeinfowidget.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 98 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 总体评分 98 分,大于 70 分通过阈值,代码质量符合要求。本次变更修复了可用空间显示含"-"异常值的Bug,代码简洁有效,无安全漏洞。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无需要修改的语法逻辑问题


2. 代码质量 ✅

评价: 优秀 ✅ 通过

潜在问题:

  1. application/widgets/customcontrol/sizeinfowidget.cpp:240 - 新增代码缺少内联注释说明规范化逻辑的目的

建议: 建议在新增代码前添加简短注释,说明规范化逻辑的目的,与commit message描述保持一致


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 无需性能优化,QString::contains()操作复杂度为O(n),字符串长度通常很短(<20字符),在paintEvent中的开销可忽略不计


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 无安全风险,代码仅处理内部成员变量的字符串显示,不涉及用户输入、文件操作或网络通信


💡 改进建议代码示例

// 绘制首页下方标注
if (m_flag) {
    DGuiApplicationHelper::ColorType themeType = DGuiApplicationHelper::instance()->themeType();
    // 规范化可用空间显示,避免负值格式化结果显示异常
    if (m_availableSize.contains("-"))
        m_availableSize = "-";
    if (themeType == DGuiApplicationHelper::LightType) {

本报告由 AI 代码审查工具自动生成

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GongHeng2017, max-lvs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GongHeng2017

Copy link
Copy Markdown
Contributor Author

/merge

@deepin-bot
deepin-bot Bot merged commit da774d0 into linuxdeepin:release/1071 Sep 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants