Skip to content

fix: stop event loop and release FileLoadThread on the exception path #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deepin-bot merged 1 commit into from
Oct 8, 2026
+4 −0
Merged

fix: stop event loop and release FileLoadThread on the exception path #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/common/fileloadthread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ void FileLoadThread::run()

file.close();
emit sigLoadFinished(encode, indata, true, false);
// Skip the common cleanup at the end of run(): stop the event loop
// and release the thread object, or both leak on the error path.
this->quit();
this->deleteLater();
Comment on lines +90 to +91

@sourcery-ai sourcery-ai Bot Sep 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): deleteLater() queues destruction of the FileLoadThread object in its owning thread, which is normally the GUI thread, before the worker thread has necessarily finished returning from run(). If that event is processed during this window, the QThread object is destroyed while still running and Qt reports QThread: Destroyed while thread is still running (and can abort).

Triggers: When the owning thread processes the deferred-delete event before the worker thread has completed its return from run().

Suggested fix: Schedule deletion from the thread's finished signal and rely on that signal for cleanup after the worker has actually terminated.

return;
}

Expand Down
Loading