Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuidePrevents shutdown-time crashes in the secondary D-Bus forwarding process by ensuring EditorApplication destruction only deletes an already-created StartManager and never creates one during teardown. Sequence diagram for safe StartManager shutdownsequenceDiagram
participant DBus as D-Bus forwarding process
participant App as EditorApplication
participant SM as StartManager
participant Qt as Qt event loop
DBus->>App: shutdown
App->>SM: instanceOrNull()
SM-->>App: m_instance
alt StartManager already exists
App->>SM: delete instanceOrNull()
SM->>Qt: teardown StartManager safely
else StartManager was never created
App-->>Qt: continue shutdown without creating StartManager
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
1. Root cause: ~EditorApplication() destructor called StartManager::instance() for null-check, but instance() is a lazy singleton that creates a new StartManager when m_instance is null. The second process (D-Bus file forwarder) never created StartManager, so the destructor unexpectedly created and immediately deleted a full StartManager during app shutdown, conflicting with Qt event loop teardown and causing SIGSEGV 2. Fix: add instanceOrNull() that returns m_instance without creating, use it in the destructor for null-check and deletion 3. Impact: only the destructor behavior changes (no longer creates StartManager on exit), existing instance() callers unaffected Log: 修复双击桌面文本文档时文本编辑器崩溃的问题 Influence: 1. Test opening text file by double-click when editor is already running, verify no crash log generated 2. Test normal editor exit after opening and editing files 3. Verify no regression on existing file open and tab management fix: 修复双击桌面文本文档时文本编辑器崩溃的问题 1. 根因：~EditorApplication() 析构函数调用 StartManager::instance() 做判空检查，但 instance() 是懒加载 单例，m_instance 为 null 时会创建新实例。第二个进程（D-Bus 文件转发者）从未创建 StartManager，析构时意外创建并立即删除 完整的 StartManager，与 Qt 事件循环关闭序列冲突导致 SIGSEGV 2. 方案：新增 instanceOrNull() 方法仅返回 m_instance 不创建实例， 析构函数改用该方法做判空检查和删除操作 3. 影响：仅析构函数行为改变（退出时不再创建 StartManager）， 现有 instance() 调用方不受影响 Log: 修复双击桌面文本文档时文本编辑器崩溃的问题 Influence: 1. 测试文本编辑器已打开时双击桌面文本文档，验证不产生崩溃日志 2. 测试正常打开文件、编辑后退出文本编辑器 3. 验证现有文件打开和标签页管理功能无回归 PMS: BUG-378901
pengfeixx
force-pushed
the
agent/pms-bug-bot/aad237e98d01
branch
from
October 9, 2026 06:02
33f60d4 to
db1cbfb
Compare
deepin pr auto review🤖 AI 代码审查报告总体评分： 📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 语法正确，逻辑清晰，无需修改。instanceOrNull() 方法正确返回 m_instance 指针，析构函数中先检查非空再删除的逻辑正确。 2. 代码质量 ✅评价： 优秀 ✅ 通过 潜在问题：
建议： 建议为 instanceOrNull() 方法添加简短注释，说明其与 instance() 的区别，例如：'// 返回单例实例，如果不存在则返回 nullptr（不创建新实例）' 3. 代码性能 ✅评价： 优秀 ✅ 通过 潜在问题： 建议： 性能良好，instanceOrNull() 为 O(1) 指针返回，且避免了析构时不必要的对象创建，实际上是性能改进。 4. 代码安全 🔒评价： 优秀 ✅ 通过
安全漏洞详情： 建议： 存在0个安全漏洞，无安全风险。变更未引入任何安全问题，反而通过防止析构时的崩溃提升了代码健壮性。 💡 改进建议代码示例// 在 startmanager.cpp 中添加注释
// 返回单例实例，如果不存在则返回 nullptr（不创建新实例）
// 与 instance() 不同，此方法不会在 m_instance 为空时创建新实例
StartManager *StartManager::instanceOrNull()
{
return m_instance;
}本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent crash on exit by using non-creating singleton accessor
StartManager::instance() for null-check, but instance() is a
lazy singleton that creates a new StartManager when m_instance
is null. The second process (D-Bus file forwarder) never created
StartManager, so the destructor unexpectedly created and
immediately deleted a full StartManager during app shutdown,
conflicting with Qt event loop teardown and causing SIGSEGV
creating, use it in the destructor for null-check and deletion
StartManager on exit), existing instance() callers unaffected
Log: 修复双击桌面文本文档时文本编辑器崩溃的问题
Influence:
running, verify no crash log generated
fix: 修复双击桌面文本文档时文本编辑器崩溃的问题
StartManager::instance() 做判空检查，但 instance() 是懒加载
单例，m_instance 为 null 时会创建新实例。第二个进程（D-Bus
文件转发者）从未创建 StartManager，析构时意外创建并立即删除
完整的 StartManager，与 Qt 事件循环关闭序列冲突导致 SIGSEGV
析构函数改用该方法做判空检查和删除操作
现有 instance() 调用方不受影响
Log: 修复双击桌面文本文档时文本编辑器崩溃的问题
Influence:
PMS: BUG-378901
Summary by Sourcery
Prevent shutdown-time crashes by using a non-creating StartManager singleton lookup during application cleanup.
Bug Fixes:
Enhancements: