Skip to content

fix: fix crash on close after editing text in zip archive #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pengfeixx wants to merge 1 commit into from
+10 −6
Closed

fix: fix crash on close after editing text in zip archive #640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/editor/editwrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,16 @@ EditWrapper::EditWrapper(Window *window, QWidget *parent)
EditWrapper::~EditWrapper()
{
qDebug() << "EditWrapper destructor";
// 必须在 delete m_pTextEdit 之前清理 m_pWaringNotices，避免 DMessageManager
// 持有 m_pTextEdit 悬空指针导致 use-after-free（bug 378881）。
// 此前 bug 78042 的崩溃根因是 delete m_pWaringNotices 位于 m_pTextEdit 之后，
// DMessageManager 在处理消息移除时访问已释放的 m_pTextEdit；将删除顺序
// 调整为先 m_pWaringNotices 后 m_pTextEdit 即可同时避免两个问题。
if (m_pWaringNotices != nullptr) {
disconnect(m_pWaringNotices);
delete m_pWaringNotices;
m_pWaringNotices = nullptr;
}
if (m_pTextEdit != nullptr) {
qDebug() << "EditWrapper destructor, m_pTextEdit not nullptr";
disconnect(m_pTextEdit);
Expand All @@ -207,12 +217,6 @@ EditWrapper::~EditWrapper()
delete m_pBottomBar;
m_pBottomBar = nullptr;
}
//delete 之后，如果出现文件被修改，需要重新加载弹框，之后，点击标签关闭，闪退问题　78042 ut002764
// if (m_pWaringNotices != nullptr) {
// disconnect(m_pWaringNotices);
// delete m_pWaringNotices;
// m_pWaringNotices = nullptr;
// }
qDebug() << "EditWrapper destructor exit";
}

Expand Down
Loading