Repository navigation
Revert "chore: migrate linglong deps to declarative buildext.apt" - #643
Conversation
This reverts commit 0fa1ed5.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReverts declarative buildext.apt dependency migration by restoring script-driven dependency handling: APT packages are downloaded and installed into the build prefix, runtime libraries are discovered through explicit targets, and .install metadata is generated during the build. Flow diagram for script-driven dependency packagingflowchart TD
A[Build starts] --> B[apt download-only dependency packages]
B --> C[install_dep into PREFIX]
C --> D[cmake configure and build]
D --> E[cmake install with install.log]
E --> F[deploy_dep scans explicit runtime targets]
F --> G[Generate .install metadata]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="linglong.yaml" line_range="23" />
<code_context>
build: |
+ # 下载和安装依赖
+ apt -y install --download-only qt6-5compat-dev qt6-base-dev qt6-tools-dev-tools qt6-tools-dev qt6-base-private-dev qt6-svg-dev libdtk6widget-dev libdtk6gui-dev libdtk6core-dev libdtk6declarative-dev libpolkit-qt6-1-dev libkf6syntaxhighlighting-dev libkf6codecs-dev libgtest-dev libgmock-dev libchardet-dev libuchardet-dev libicu-dev deepin-event-log
+ bash ./install_dep /var/cache/apt/archives "$PREFIX"
+
</code_context>
<issue_to_address>
**Stale archives alter the prefix**
When the apt archive directory contains older versions of requested packages or unrelated `.deb` files, `install_dep` processes every `.deb` in the archive directory, so an older package can overwrite the requested version and unrelated packages can be copied into `$PREFIX` and recorded in `packages.list`.
Restrict extraction to the requested packages and select the requested version before copying files.
Also at `linglong.yaml:24`.
</issue_to_address>|
|
||
| build: | | ||
| # 下载和安装依赖 | ||
| apt -y install --download-only qt6-5compat-dev qt6-base-dev qt6-tools-dev-tools qt6-tools-dev qt6-base-private-dev qt6-svg-dev libdtk6widget-dev libdtk6gui-dev libdtk6core-dev libdtk6declarative-dev libpolkit-qt6-1-dev libkf6syntaxhighlighting-dev libkf6codecs-dev libgtest-dev libgmock-dev libchardet-dev libuchardet-dev libicu-dev deepin-event-log |
There was a problem hiding this comment.
🟡 Medium · Stale archives alter the prefix
When the apt archive directory contains older versions of requested packages or unrelated .deb files, install_dep processes every .deb in the archive directory, so an older package can overwrite the requested version and unrelated packages can be copied into $PREFIX and recorded in packages.list.
Restrict extraction to the requested packages and select the requested version before copying files.
Also at linglong.yaml:24.
Prompt for AI agents
In `linglong.yaml` at line 23:
**Stale archives alter the prefix**
When the apt archive directory contains older versions of requested packages or unrelated `.deb` files, `install_dep` processes every `.deb` in the archive directory, so an older package can overwrite the requested version and unrelated packages can be copied into `$PREFIX` and recorded in `packages.list`.
Restrict extraction to the requested packages and select the requested version before copying files.
Also at `linglong.yaml:24`.|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reverts #642
Summary by Sourcery
Restore the previous script-based Linglong dependency workflow for building and packaging deepin-editor.
Enhancements:
Build:
Chores: