feat: drop alpha from accent color in appearance protocols - #114
Merged
Merged
Conversation
1. Remove the `a` argument from set_accent_color in treeland-appearance-manager-unstable-v1.xml 2. Remove the `a` argument from accent_color event in treeland-appearance-unstable-v1.xml 3. Add 0.7.0 breaking-change entries to dde/ and public/ READMEs 4. Bump project version to 0.7.0 in CMakeLists.txt Log: Accent color is now opaque RGB (r, g, b) on the wire; the alpha channel is no longer carried by either the privileged set request or the read-only observer event. Influence: 1. Bind treeland_appearance_manager_v1 and call set_accent_color with three uint args (r, g, b); verify the compositor applies the color and no longer reads a trailing alpha value 2. Bind treeland_appearance_v1 and confirm the accent_color event delivers exactly three uint args (r, g, b) on initial bind and on subsequent changes 3. Verify clients sending the old four-arg (r, g, b, a) signature are rejected or handled per compositor policy after the wire change feat: 活动色协议去掉 alpha 分量 1. 移除 treeland-appearance-manager-unstable-v1.xml 中 set_accent_color 的 `a` 参数 2. 移除 treeland-appearance-unstable-v1.xml 中 accent_color 事件的 `a` 参数 3. 在 dde/ 与 public/ 的 README 中补充 0.7.0 破坏性变更条目 4. CMakeLists.txt 项目版本号升至 0.7.0 Log: 活动色现上线缆为不透明 RGB(r, g, b);特权设置请求与只读观察事件均不再携带 alpha 通道。 Influence: 1. 绑定 treeland_appearance_manager_v1 并以三个 uint 参数(r, g, b)调用 set_accent_color,验证合成器应用该颜色且不再读取末尾 alpha 值 2. 绑定 treeland_appearance_v1,确认 accent_color 事件在初始绑定及后续变化时均只发送三个 uint 参数(r, g, b) 3. 验证发送旧四参数(r, g, b, a)签名的客户端在线缆变更后被拒绝或按合成器策略处理
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wineee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThis PR introduces the 0.7.0 breaking wire-format change that removes alpha from both accent-color setting and notification, so clients now send and receive only opaque r, g, b uint values; corresponding English and Chinese migration notes are added. Sequence diagram for opaque accent color protocolsequenceDiagram
participant Client
participant Compositor
participant Observer
Client->>Compositor: set_accent_color(r, g, b)
Compositor-->>Observer: accent_color(r, g, b)
Note over Client,Observer: Alpha is not carried on the wire
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aargument from set_accent_color in treeland-appearance-manager-unstable-v1.xmlaargument from accent_color event in treeland-appearance-unstable-v1.xmlLog: Accent color is now opaque RGB (r, g, b) on the wire; the alpha channel is no longer carried by either the privileged set request or the read-only observer event.
Influence:
feat: 活动色协议去掉 alpha 分量
a参数a参数Log: 活动色现上线缆为不透明 RGB(r, g, b);特权设置请求与只读观察事件均不再携带 alpha 通道。
Influence:
Summary by Sourcery
Adopt opaque RGB accent colors across the appearance protocols and release the breaking wire-format change as version 0.7.0.
Enhancements:
Build:
Documentation: