Add project name and logo to My CLAs API (prod) - #5143
Conversation
Signed-off-by: Michal Lehotsky <mlehotsky@linuxfoundation.org>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Adds project display names and logos to /v4/my-clas for Self Serve integration.
Changes:
- Resolves project or foundation metadata with graceful fallbacks.
- Adds Swagger fields and project-service wiring.
- Adds tests and updates API documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
docs/MY_CLAS_API.md |
Documents project metadata and fallback behavior. |
cla-backend-go/v2/my_clas/service.go |
Resolves and caches project information. |
cla-backend-go/v2/my_clas/service_test.go |
Tests resolution, ambiguity, caching, and failures. |
cla-backend-go/swagger/common/my-cla.yaml |
Defines the new response fields. |
cla-backend-go/cmd/server.go |
Injects the project-service client. |
Project name and logo on the My CLAs API rows - needed by SelfServe integration milestone M1.
Promotes #5133 to PROD. The UI's Project cell needs a real project display name and logo instead of the current
projectName = claGroupNameUUID/name fallback.projectNameandprojectLogotoGET /v4/my-clasrowsproject_sfid == foundation_sfid); ambiguous multi-project CLA Groups leave both fields empty so the consumer falls back toclaGroupNamenilclient degrades to an empty logo rather than failing the whole listingproject_service.GetClient()incmd/server.go; swagger, tests, anddocs/MY_CLAS_API.mdupdatedThe branch tree is byte-identical to
dev(tree91822b63afef8248de31eb61814b3e60e1bf93b6), where fullbuild-test-lint,cypress-functional, and a dev deploy passed on #5133.Note:
mainCI does not run build/test/lint, andmake swaggerregeneratesmodels.MyCla.{ProjectName,ProjectLogo}at deploy time from the editedmy-cla.yaml.Signed-off-by: Michal Lehotsky mlehotsky@linuxfoundation.org