Skip to content

Add project name and logo to My CLAs API (prod) - #5143

Merged
mlehotskylf merged 1 commit into
mainfrom
unicron-my-clas-project-name-logo-prod
Aug 4, 2026
Merged

Add project name and logo to My CLAs API (prod)#5143
mlehotskylf merged 1 commit into
mainfrom
unicron-my-clas-project-name-logo-prod

Conversation

@mlehotskylf

Copy link
Copy Markdown
Collaborator

Project name and logo on the My CLAs API rows - needed by SelfServe integration milestone M1.

Promotes #5133 to PROD. The UI's Project cell needs a real project display name and logo instead of the current projectName = claGroupName UUID/name fallback.

  • Adds projectName and projectLogo to GET /v4/my-clas rows
  • A CLA Group resolves to its Salesforce project (single project-level mapping) or its foundation (foundation marker, project_sfid == foundation_sfid); ambiguous multi-project CLA Groups leave both fields empty so the consumer falls back to claGroupName
  • A project-service miss or nil client degrades to an empty logo rather than failing the whole listing
  • Wires project_service.GetClient() in cmd/server.go; swagger, tests, and docs/MY_CLAS_API.md updated

The branch tree is byte-identical to dev (tree 91822b63afef8248de31eb61814b3e60e1bf93b6), where full build-test-lint, cypress-functional, and a dev deploy passed on #5133.

Note: main CI does not run build/test/lint, and make swagger regenerates models.MyCla.{ProjectName,ProjectLogo} at deploy time from the edited my-cla.yaml.

Signed-off-by: Michal Lehotsky mlehotsky@linuxfoundation.org

Signed-off-by: Michal Lehotsky <mlehotsky@linuxfoundation.org>
Copilot AI balanced review requested due to automatic review settings August 4, 2026 09:25
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1f28b649-d48e-40f1-b4b1-20740422860a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds project display names and logos to /v4/my-clas for Self Serve integration.

Changes:

  • Resolves project or foundation metadata with graceful fallbacks.
  • Adds Swagger fields and project-service wiring.
  • Adds tests and updates API documentation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docs/MY_CLAS_API.md Documents project metadata and fallback behavior.
cla-backend-go/v2/my_clas/service.go Resolves and caches project information.
cla-backend-go/v2/my_clas/service_test.go Tests resolution, ambiguity, caching, and failures.
cla-backend-go/swagger/common/my-cla.yaml Defines the new response fields.
cla-backend-go/cmd/server.go Injects the project-service client.

@mlehotskylf
mlehotskylf merged commit fe30368 into main Aug 4, 2026
8 checks passed
@mlehotskylf
mlehotskylf deleted the unicron-my-clas-project-name-logo-prod branch August 4, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants