Skip to content

docs: add /tinybird skill for pipe and datasource deploys - #2087

Open
emlimlf wants to merge 2 commits into
mainfrom
docs/add-tinybird-skill
Open

docs: add /tinybird skill for pipe and datasource deploys#2087
emlimlf wants to merge 2 commits into
mainfrom
docs/add-tinybird-skill

Conversation

@emlimlf

@emlimlf emlimlf commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a /tinybird skill documenting the edit-and-deploy cycle for Tinybird pipes/datasources (venv setup, workspace selection between lfx_insights_stg/lfx_insights, format, push, PR, prod rollout gated on explicit confirmation)
  • Registers the skill in .claude/rules/skill-guidance.md with trigger phrases

Context

Tinybird resources live in the crowd.dev repo, but Insights is the primary consumer of that data and had no guidance pointing at the existing crowd.dev README describing the workflow. This skill wraps that workflow for use from this repo, without duplicating or replacing the crowd.dev docs (local Docker testing, backfills, and schema iteration stay out of scope and link back to the source README).

Test plan

  • Confirm the skill loads in a fresh Claude Code session in this repo
  • Confirm it correctly locates a sibling crowd.dev checkout and refuses to operate on submodules/crowd.dev
  • Confirm it prompts for confirmation before any tb push to the lfx_insights (prod) workspace

Documents the edit-and-deploy cycle for Tinybird pipes/datasources
against the standalone crowd.dev checkout, since that work is not
otherwise captured anywhere in this repo despite Insights being the
primary consumer of that data.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Copilot AI balanced review requested due to automatic review settings August 14, 2026 02:49
@emlimlf
emlimlf requested a review from joanagmaia August 14, 2026 02:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a guided Tinybird deployment workflow for Insights contributors.

Changes:

  • Documents Tinybird setup, staging deployment, PR, and production rollout.
  • Registers /tinybird with intent-based trigger phrases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
.claude/skills/tinybird/SKILL.md Defines the Tinybird workflow and guardrails.
.claude/rules/skill-guidance.md Registers and maps /tinybird triggers.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .claude/skills/tinybird/SKILL.md Outdated
Comment thread .claude/skills/tinybird/SKILL.md Outdated
Comment thread .claude/skills/tinybird/SKILL.md
Comment thread .claude/skills/tinybird/SKILL.md Outdated
Comment thread .claude/skills/tinybird/SKILL.md
Address review comments from copilot-pull-request-reviewer[bot]:

- .claude/skills/tinybird/SKILL.md: replaced Read-based .tinyb check with a jq
  field extraction so the admin token never enters the transcript (per
  copilot-pull-request-reviewer[bot])
- .claude/skills/tinybird/SKILL.md: wrapped the format.sh step in a subshell so
  the working directory stays at the Tinybird project root for the following
  tb push (per copilot-pull-request-reviewer[bot])
- .claude/skills/tinybird/SKILL.md: staging deploy now explicitly selects and
  verifies lfx_insights_stg before pushing, since .tinyb can be left pointed
  at production (per copilot-pull-request-reviewer[bot])
- .claude/skills/tinybird/SKILL.md: PR step now defers to crowd.dev's own
  commit-workflow.md (CM-XXX, not Insights' IN-XXX) since the change happens
  in that checkout (per copilot-pull-request-reviewer[bot])
- .claude/skills/tinybird/SKILL.md: production deploy now gated on the PR
  being merged and the local checkout being clean and up to date, matching
  the README's documented order (per copilot-pull-request-reviewer[bot])

Resolves 5 review threads.

Signed-off-by: Efren Lim <elim@linuxfoundation.org>
Copilot AI review requested due to automatic review settings August 14, 2026 07:37
@emlimlf

emlimlf commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator Author

Review Feedback Addressed

Commit: 301cc5d

Changes Made

  • .claude/skills/tinybird/SKILL.md (auth check): replaced the Read-based .tinyb check with a jq field extraction so the admin token never enters the transcript (per copilot-pull-request-reviewer[bot])
  • .claude/skills/tinybird/SKILL.md (format step): wrapped format.sh in a subshell so the working directory stays at the Tinybird project root for the following tb push (per copilot-pull-request-reviewer[bot])
  • .claude/skills/tinybird/SKILL.md (staging deploy): now explicitly runs tb workspace use lfx_insights_stg + tb workspace ls before pushing, since .tinyb can be left pointed at production (per copilot-pull-request-reviewer[bot])
  • .claude/skills/tinybird/SKILL.md (PR step): now defers to crowd.dev's own commit-workflow.md (CM-XXX, branch/title conventions) instead of this repo's IN-XXX convention, since the change happens in the crowd.dev checkout (per copilot-pull-request-reviewer[bot])
  • .claude/skills/tinybird/SKILL.md (production deploy): added a merge gate — requires the PR to be merged and the local checkout clean/up to date before switching to production, matching the order in crowd.dev's README (per copilot-pull-request-reviewer[bot])

Threads Resolved

5 of 5 unresolved threads addressed in this iteration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.claude/skills/tinybird/SKILL.md:130

  • pr-title-jira-key-lint.yml does not enforce this requirement: when the key is absent, it creates a neutral check rather than a failing one. The CM-key requirement is still documented by crowd.dev's commit workflow, but describing it as CI-enforced is inaccurate.
in parens at the end, `--signoff -S`, and the PR title must carry the CM key (CI-enforced by
`pr-title-jira-key-lint.yml`). Note: crowd.dev's Tinybird CI (`tinybird-ci.yml`) only checks
`tb fmt --diff` — a green CI does not mean the SQL itself is correct, say so if asked.

.claude/skills/tinybird/SKILL.md:82

  • This runnable block selects staging and then immediately switches to production. Following it top-to-bottom leaves .tinyb on lfx_insights, so the staging tb pull in step 5 can pull the wrong resource version. Keep production selection exclusively in step 9 and make staging the only selection here.
```bash
tb workspace ls
tb workspace use lfx_insights_stg   # staging/dev
tb workspace use lfx_insights       # production
</details>

@joanagmaia joanagmaia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @emlimlf I think this is pretty cool, but it would make more sense in the linuxfoundation/crowd.dev repo since all the tinybird files live there and the code changes occur there. Full context will also be there. Let me know if you have a strong reason for keeping it on tihs repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants