fix: remove benchmark scoring from contributions outside work hours widget (IN-1230) - #2107
Open
gaspergrom wants to merge 3 commits into
Open
fix: remove benchmark scoring from contributions outside work hours widget (IN-1230)#2107gaspergrom wants to merge 3 commits into
gaspergrom wants to merge 3 commits into
Conversation
…tab IN-1230 Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the disputed “Contributions outside work hours” metric from Development insights.
Changes:
- Removes widget registration, configuration, and UI.
- Removes its client service, query key, and API endpoint.
- Leaves stale documentation and breaks existing public embeds.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
frontend/server/api/widget/development/contribution-outside.get.ts |
Deletes the widget endpoint. |
frontend/app/components/shared/types/tanstack.ts |
Removes its query key. |
frontend/app/components/modules/widget/types/widget.ts |
Removes its widget enum. |
frontend/app/components/modules/widget/services/development.api.service.ts |
Removes client fetching logic. |
frontend/app/components/modules/widget/config/widget.config.ts |
Removes global widget registration. |
frontend/app/components/modules/widget/config/widget-area.config.ts |
Removes it from Development. |
frontend/app/components/modules/widget/config/development/contributions-outside-work-hours/contributions-outside-work-hours.vue |
Deletes the widget UI. |
frontend/app/components/modules/widget/config/development/contributions-outside-work-hours/contributions-outside-work-hours.config.ts |
Deletes widget metadata and capabilities. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| Widget.ISSUES_RESOLUTION, | ||
| Widget.COMMIT_ACTIVITIES, | ||
| Widget.PULL_REQUESTS, | ||
| Widget.ACTIVE_DAYS, |
| [Widget.ISSUES_RESOLUTION]: issuesResolution, | ||
| [Widget.COMMIT_ACTIVITIES]: commitActivities, | ||
| [Widget.PULL_REQUESTS]: pullRequests, | ||
| [Widget.ACTIVE_DAYS]: activeDays, |
…-1230 The dedicated API endpoint for this fetcher was already removed in the prior commit. Nothing else calls it (health-score.helpers.ts reads these fields from a separate combined pipe), so it and its associated types/mock/test were dead code. Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.
Suppressed comments (1)
frontend/app/components/modules/widget/config/widget-area.config.ts:48
- Removing this widget leaves the user-facing Development documentation inconsistent with the UI:
frontend/docs/features/community-collections/index.md:82still lists “Contributions outside work hours,” andfrontend/docs/metrics/development/index.md:41-47still documents it as an available metric. Please remove or revise those sections in this PR so users are not directed to a metric that no longer exists.
Widget.ACTIVE_DAYS,
… benchmark scoring IN-1230 Widget stays visible on the Development tab with original copy; only the pass/fail benchmark verdict (shown inline and on the Overview Health Score card) is removed, per updated ticket scope. Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
| @@ -16,45 +16,6 @@ const contributionsOutsideWorkHours: WidgetConfig = { | |||
| share: true, | |||
| embed: true, | |||
| snapshot: true, | |||
gaspergrom
force-pushed
the
feat/IN-1230
branch
from
August 25, 2026 12:28
86287dc to
57383b4
Compare
gaspergrom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
frontend/app/components/modules/widget/config/development/contributions-outside-work-hours/contributions-outside-work-hours.config.tsbenchmarkconfig block (39 lines); widget otherwise unchangedRemoving
benchmark(an optionalWidgetConfigfield) is sufficient on its own: the sharedbenchmarks-wrap.vuecomponent treats anundefinedbenchmarkConfigas not-visible, so this suppresses the verdict UI everywhere it renders — inline on the widget and on the Overview Health Score card — with no other code changes needed.JIRA
IN-1230 — Remove 'Contributions outside work hours' benchmark from UI
Deploy order
No deploy ordering constraints — self-contained to this repo.
DB migrations
No DB migrations.
Test plan
pnpm tsc-checkpasses (no type errors)pnpm testpassesChecklist
git commit --signoff -Son every commit