Repository navigation
fix: scope node --test to compiled build output - #592
Merged
Merged
Conversation
Bare 'node --test' discovers both the compiled tests in build/ and the TypeScript sources in src/. The src/*.test.ts files import sibling modules as '../../binary.index.js', which only exists under build/, so on Node >=22.6 (where .ts test files are picked up natively) they fail at module resolution with ERR_MODULE_NOT_FOUND. Restrict discovery to the compiled output, which is what these tests were always intended to run against.
amfage
requested review from
Wentao-Kuang and
ccbblin
and removed request for
a team
August 30, 2026 22:35
Wentao-Kuang
approved these changes
Aug 30, 2026
amfage
added a commit
that referenced
this pull request
Aug 30, 2026
On Node >=22.6 tests fail at module resolution with ERR_MODULE_NOT_FOUND. Restrict discovery to the compiled output, which is what these tests were originally run against.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Node >=22.6 tests fail at module resolution with ERR_MODULE_NOT_FOUND.
Restrict discovery to the compiled output, which is what these tests were originally run against.