Skip to content

chore(pinact): pin/update GitHub Actions #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidliu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(pinact): pin/update GitHub Actions #1035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
submodules: recursive

- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
java-version: '17'
distribution: 'adopt'

@devin-ai-integration devin-ai-integration Bot Oct 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Unsupported Java distribution blocks builds and releases

Each Java setup step passes adopt to actions/setup-java v6, which no longer supports that distribution. Setup fails before the CI, dependency-diff, and publishing jobs reach Gradle.

Learn more

actions/setup-java v6 removed the adopt distribution alias. Its distribution factory returns no installer for that value, so each affected setup step fails before any later Gradle command runs. The same value appears in both Java setup steps in the Android workflow and in the changesets, dependency-diff, and manual-release workflows.

Example: A pull request starts the Android CI build job. The Java setup step requests adopt, fails to find a supported distribution, and never runs the SDK tests.

Recommended fix: Set distribution: 'temurin' at all five Java setup steps, keeping the pinned v6 action.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Expand Down Expand Up @@ -246,7 +246,7 @@ jobs:
name: Diffuse checker
needs: [build, diffuse_prep]
steps:
- uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
- uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
java-version: '17'
distribution: 'adopt'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/changesets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: pnpm/action-setup@0977fd99725f1db4007ccb2928dbb4e90d06cc86 # v6.0.10
- uses: pnpm/action-setup@ea17c68df8912ef543352723c149a84f56e3d413 # v6.1.0
with:
version: 10

Expand All @@ -46,7 +46,7 @@ jobs:

- name: Create Release Pull Request
id: changesets
uses: changesets/action@a45c4d594aa4e2c509dc14a9f2b3b67ba3780d0d # v1.9.0
uses: changesets/action@ae32849d5ba541f9ae29e40e22a623bc13562f51 # v2.1.2
with:
title: ${{ steps.getver.outputs.TITLE }}
commit: ${{ steps.getver.outputs.TITLE }}
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
submodules: recursive

- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
java-version: '17'
distribution: 'adopt'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/dependency_diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
- uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
distribution: 'adopt'
java-version: 17
Expand All @@ -29,7 +29,7 @@ jobs:

- id: dependency-diff
name: Generate dependency diff
uses: usefulness/dependency-tree-diff-action@a9b2aa1567cc3b9c860c373479a24dc60429bfda # v2.3.0
uses: usefulness/dependency-tree-diff-action@ff9888adef68e2c4117884a13d36c7fe390b698b # v2.4.0
with:
project: 'livekit-android-sdk'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
submodules: recursive

- name: set up JDK 17
uses: actions/setup-java@b6effb05e454b25005698d916606bdc6ffcbf961 # v5.7.0
uses: actions/setup-java@de7274f081f381c8f8158605e0321c36c376e2e6 # v6.0.1
with:
java-version: '17'
distribution: 'adopt'
Expand Down
Loading