Skip to content

Update module github.com/pion/rtp to v2 - #539

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-pion-deps
Open

renovate[bot] wants to merge 1 commit into
mainfrom
renovate/major-pion-deps

Conversation

@renovate

@renovate renovate Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/pion/rtp v1.10.5 → v2.0.0 age confidence

Release Notes

pion/rtp (github.com/pion/rtp)

v2.0.0

Compare Source

v1.10.6

Compare Source

Changelog

  • 9a8f935 Avoid quadratic copying in AV1 fragment reassembly
  • f34b779 Zero RTP padding when marshaling into reused buffers
  • e24c716 Fix panics in h264 Spreader.Process
  • 3a98767 Always use 2-byte PictureID in VP8Payloader (#​377)
  • cbf78a2 Always send PictureID 0 in VP8Payloader
  • 6d66ac7 Update CI configs to v0.12.8
  • d312bf6 Filter OBU-padding
  • 8e8b023 Update CI configs to v0.12.7
  • 4129840 Update module github.com/stretchr/testify to v1.12.1 (#​369)
  • 533cf7c Update module github.com/stretchr/testify to v1.12.0 (#​368)
  • 4340606 Update CI configs to v0.12.6

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "on sunday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread go.mod
github.com/pion/interceptor v0.1.49
github.com/pion/rtcp v1.2.19
github.com/pion/rtp v1.10.5
github.com/pion/rtp/v2 v2.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 RTP upgrade leaves WHIP on v1

Adding github.com/pion/rtp/v2 does not upgrade WHIP: createDepacketizer and RelayWhipTrackHandler still import v1. The receiver keeps the old RTP behavior and misses the v2 fixes.

Learn more

Go treats github.com/pion/rtp and github.com/pion/rtp/v2 as separate modules. Adding the v2 requirement does not replace the v1 module. Both createDepacketizer and RelayWhipTrackHandler continue using v1 imports, so this change does not upgrade their RTP processing.

Example: A WHIP video track still creates its H264 depacketizer from the v1 codecs package after this change, even though go.mod now lists v2.

Recommended fix: Migrate the direct RTP imports to github.com/pion/rtp/v2 and its codecs, adapting interfaces and dependent APIs as needed. Retain the v1 requirement only if transitive consumers still require it, and run go mod tidy after the migration.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@renovate
renovate Bot force-pushed the renovate/major-pion-deps branch from 73b9a73 to 1d529b4 Compare October 25, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants