Honor the exact light-time convergence tolerance - #146
Merged
SuperdoerTrav merged 1 commit intoSep 19, 2026
Merged
SuperdoerTrav merged 1 commit into
SuperdoerTrav merged 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 97.39% 97.39%
=======================================
Files 17 17
Lines 5897 5897
=======================================
Hits 5743 5743
Misses 154 154
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sylvesterkaczmarek
marked this pull request as ready for review
September 19, 2026 20:51
Contributor
Author
|
Thank you for merging this. Much appreciated, and I’m glad to keep contributing to SSAPy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the existing 1 ps tolerance to each light-time update before reducing the convergence condition. The previous
np.any(abs(delta)) > 1e-12compared a Boolean with the tolerance, effectively requiring bitwise-stable delays.This can reject already-converged observations when floating-point epoch rounding produces a sub-picosecond cycle. Two real Keplerian examples reproduce the failure in
radec(..., obsAngleCorrection="exact"). The numerical tolerance and iteration limit are unchanged; nonconvergent and NaN updates still raise.Validation
Python 3.12, NumPy 2.5.3, SciPy 1.18.1 on macOS arm64:
8bb784c): 4 failed, 2 passed. With the fix: all 6 passed.compute.py. Syntax checks andgit diff --checkpass.No native code or public API changes. Other operating systems were not tested locally.