Skip to content

fix(ssh): build remote container workdir with path.Join #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pramod-Pasala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ssh): build remote container workdir with path.Join #1995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions cmd/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"io"
"os"
"os/exec"
"path/filepath"
"path"
"strings"
"time"

Expand Down Expand Up @@ -495,7 +495,10 @@ func (cmd *SSHCmd) startTunnel(ctx context.Context, devPodConfig *config.Config,
}
}

workdir := filepath.Join("/workspaces", workspaceClient.Workspace())
// build the remote workdir with path.Join instead of filepath.Join,
// because the path is used on a Linux container even when devpod
// itself runs on Windows, where filepath.Join would use backslashes
workdir := path.Join("/workspaces", workspaceClient.Workspace())
if cmd.WorkDir != "" {
workdir = cmd.WorkDir
}
Expand Down