Repository navigation
Conversation
sharkdp
changed the title
sharkdp
marked this pull request as ready for review
November 3, 2026 10:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject exit codes other than 0 (success) and 1 (diagnostics) for every type checker.
I checked the upstream exit-code implementations for Zuban, Pyright, Pyrefly, ty, and mypy. All of them use 0 for "no diagnostics", 1 for "diagnostics", and other exit codes for unrelated problems.
This is related to the discussion in #160 and addresses the zuban / SQLAlchemy problem. When merged in isolation, this PR will also affect the zuban run on Salt, since zuban currently exits with exit code 2 on that project (No Python files found to check). This seems like a good thing. Once we ignore the mypy configuration for zuban, the Salt project should be included again.