Repository navigation
Conversation
sharkdp
marked this pull request as draft
November 3, 2026 10:24
sharkdp
changed the title
sharkdp
marked this pull request as ready for review
November 3, 2026 10:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zuban currently runs without the generated benchmark config, so project-specific mypy settings can exclude benchmark targets or disable checks. Pass a dedicated
zuban.benchmark.inivia--config-file, with the selected paths infilesandcheck_untyped_defs = True, matching the mypy benchmark setup.The separate config filename also keeps Zuban's config independent of
mypy.benchmark.ini.This addresses the configuration problem reported in #160.
With this fix, these are the results I get for Zuban 0.10.1: