Repository navigation
Conversation
sharkdp
marked this pull request as ready for review
November 3, 2026 11:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161.
Use a blocking
wait4()on Linux to collect peak RSS when the type-checker exits (the OOM watcher still uses/proc/<pid>/statusfor querying while the process is still running).I ran a benchmark for each type-checker on "cerify". Each cell shows min..max peak RSS in MiB for five benchmarking runs. GNU
timeis used for comparison. As we can tell from this table, the new ("After") results are closed to thetimemeasurements, especially for the fast-running type checkers. The previous implementation could miss as much as 13 MiB, or 20% of the peak RSS (see e.g. the "min" times in the Pyrefly row):time