Skip to content

test(dashboard): follow goal request owner - #5257

Closed
Duang777 wants to merge 4 commits into
mainfrom
codex/fix-goal-create-workspace-contract
Closed

Duang777 wants to merge 4 commits into
mainfrom
codex/fix-goal-create-workspace-contract

Conversation

@Duang777

Copy link
Copy Markdown
Collaborator

Summary

  • make the Personal Workspace contract inspect goal-create-request.ts, which now owns Goal creation parameters
  • keep a caller assertion that workspace-action-form.tsx delegates to the shared builder
  • restore the workspace_ref: "current" contract check after feat(collaboration): bind inbox continuity to GoalRef #5106 moved the implementation

Validation

  • node apps/presentation/dashboard/src/features/personal-workspace/personal-workspace-contract.test.mjs
  • uv run loopx canary premerge --from-git-diff
  • git diff --check

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
…-workspace-contract

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Copy link
Copy Markdown
Collaborator Author

Exact-head handoff for fe41f164ed398c80fbaab1eb5da1fc71fd599b1e: the contract now follows the shared goalCreateRequest owner and still checks that workspace-action-form.tsx delegates to that builder. Full GitHub CI is green, including packaged Frontstage, Dashboard acceptance, all three TypeScript shards, desktop artifacts, and merge-gate. This is test-only and changes no production behavior. The same stale owner assertion is the sole Frontstage failure currently visible on #5130 and #5246; merging this restores the main-branch contract before those branches sync.

@Duang777

Copy link
Copy Markdown
Collaborator Author

Synced the branch with current main after #5130 landed. The new exact head is 64f3f035bff1095a1e1f64eca5961fa41362075d; the PR diff remains one contract-test file. The previous head completed the full CI matrix successfully, and the Personal Workspace contract smoke also passes locally on this head. Fresh CI is running.

@Duang777

Copy link
Copy Markdown
Collaborator Author

Superseding the earlier fe41f164ed398c80fbaab1eb5da1fc71fd599b1e handoff: the current exact head is 64f3f035bff1095a1e1f64eca5961fa41362075d after syncing the branch with the main that includes #5130. The relative diff remains test-only: one Personal Workspace contract-test file, four changed lines. Local verification on this head passed the contract smoke, loopx canary premerge --from-git-diff (2/2, no manual holds), and git diff --check. Fresh GitHub CI is now fully green, including chat-bundle, packaged Frontstage builds, Dashboard acceptance, all three TypeScript shards, TypeScript coverage, desktop checks, and merge-gate. Ready for maintainer review and merge.

@Duang777

Copy link
Copy Markdown
Collaborator Author

Current exact-head handoff: b69a1aa2a44fe68c24f3f7525f551fdf503407e6 has completed the full CI matrix successfully, including Dashboard acceptance, all three TypeScript shards, TypeScript coverage, packaged Frontstage, desktop checks, DCO, and merge-gate. The PR remains a test-only change to one Personal Workspace contract file and GitHub reports it as mergeable. main has advanced again, so the branch is marked behind; I am leaving it unchanged rather than restarting CI after every unrelated main update. Ready for maintainer review and merge-window sync if required.

@Duang777

Copy link
Copy Markdown
Collaborator Author

Final exact-head handoff, superseding the earlier 64f3f035bff1095a1e1f64eca5961fa41362075d note: GitHub update-branch synced current main into 065383843ff0800a5b65f49b6225accd772d12ab. The PR diff remains one Personal Workspace contract-test file (3 additions, 1 deletion). Exact-tree local verification passed the contract smoke, loopx canary premerge --from-git-diff (2/2, no manual holds), and git diff --check. Fresh CI on this exact head is fully green, including both builds, desktop checks, chat-bundle, Dashboard acceptance, all TypeScript shards, coverage, and merge-gate. Ready for maintainer review and merge.

@mergify

mergify Bot commented Sep 28, 2026

Copy link
Copy Markdown

This pull request has merge conflicts with main and cannot be merged
until they are resolved. Please rebase or merge the base branch, @Duang777.

Choose the remote for the base repository, not an out-of-date fork.
For a fork clone, first inspect git remote -v; upstream must point
to https://github.com/loopx-project/loopx.git. If it is absent, add it
with git remote add upstream https://github.com/loopx-project/loopx.git.
Then run:

git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEAD

For a same-repository clone whose origin points to
https://github.com/loopx-project/loopx.git, use origin instead of
upstream for fetch/rebase. If you prefer merging the base, use
git merge <base-remote>/main and push normally.

Keep the DCO Signed-off-by trailer on every commit when you rebase.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase Mergify: the pull request has merge conflicts with its base branch label Sep 28, 2026
@Duang777

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #5265, merged as f56482cfd2589d68907c09513bd42826f81a588b. That change covers the same regression with direct goalCreateRequest behavior checks and packaged browser request assertions, while this PR only moves the source-text assertion to the shared builder. I verified the Personal Workspace contract smoke on current main@efaa18b8059e6b90d4b29ff00ebe2afdf94c8570; it passes. Since #5257 now conflicts with that stronger main-branch test, resolving and merging it would duplicate or weaken the accepted coverage.

@Duang777 Duang777 closed this Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Mergify: the pull request has merge conflicts with its base branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant