Conversation
…-cli The workspace loaded Goal repository contexts and Lark connections with one Promise.all. Without lark-cli every Lark request returns 503, which also dropped every Goal's repository context, so the Goal drawer silently lost its repository card. Load the two optional sources independently. In Lark settings, a lark_cli_not_installed or lark_cli_not_executable answer now also disables New Lark App next to the existing explanation, instead of letting the setup dialog fail with the same error. Signed-off-by: song <liusongstep@gmail.com>
A new lark-cli-missing scenario answers Lark requests with the service's lark_cli_not_installed 503 and requires the Goal repository card to stay visible and New Lark App to be disabled. Signed-off-by: song <liusongstep@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
lark-cli, every/api/chat/lark/*request returns 503lark_cli_not_installed. (1) The workspace fetched Goal repository contexts and Lark connections with onePromise.all, so that 503 also discarded every Goal's repository context and the Goal drawer silently lost its repository card. (2) Lark settings explained thatlark-cliis missing but still offered New Lark App, whose setup dialog then failed with the same error.lark-cliabsent, before the Goal drawer had no repository card and New Lark App was enabled; after the repository card is shown and New Lark App is disabled next to the existing未发现 lark-cli…explanation.main.Scope And Continuation
lark_cli_not_installed/lark_cli_not_executable, which the Chat service resolves once at startup; other Lark errors keep the current behavior.lark-cliis missing;/api/chat/capabilitiesalready exposeslark_cli.available, and gating that request on it would need the capability threaded fromdashboard-page.tsx. Not needed for this fix.Validation
staticpassednpx tsc --noEmitinapps/presentation/dashboard.integrationpassedLOOPX_PERSONAL_WORKSPACE_SCENARIO=lark-cli-missing node examples/personal-workspace-browser-smoke.mjs(2 runs): Lark requests answer the service's 503; requires theloopx-ai/loopxrepository card in the Goal drawer and a disabled New Lark App.regression_paritypassedintegrationpassedmainalso pass here, includingtyped-actions(repository card with Lark available).real_entrypointpassedloopx serve-status+loopx chaton an isolated synthetic registry on a host withoutlark-cli:mainshowed no repository card and an enabled New Lark App; this branch shows the card and disables the button.integrationnot_rungoal-draft,capability-scope,steward-group-trigger,conversation-input,automation-cadence,steward-model-settings) already fail on a cleanmaincheckout.main.Frontend / Visual Evidence
lark-climessage.lark-climissing (screenshots available on request; not attachable from the CLI).Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
N/A
Boundary Checklist
none.Signed-off-bytrailer (git commit -s).Future-facing refactor pass: considered threading
capabilities.lark_cliinto the workspace; deferred because the Settings page already receives the typed error code and the fix does not need a second source of the same fact.