Skip to content

fix(app): save interval settings without a mandatory reason #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 2 commits into from
Sep 30, 2026
Merged

fix(app): save interval settings without a mandatory reason #5325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e5c20a
fix(app): simplify automatic interval settings saves
huangruiteng Sep 29, 2026
ae0925b
docs: clarify cadence owner intent and settings acceptance
huangruiteng Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 75 additions & 70 deletions apps/presentation/dashboard/src/features/personal-workspace/automation-cadence-settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useMemo, useState } from "react";
import { useEffect, useMemo, useRef, useState } from "react";
import { AlertTriangle, RefreshCw } from "lucide-react";

import {
Expand All @@ -8,108 +8,108 @@ import {
import { useWorkspaceI18n } from "./i18n";
import type { WorkspaceGoal } from "./personal-workspace-model";

type Scope = "goal" | "agent" | "automation";

export function AutomationCadenceSettings({ goal }: Readonly<{ goal: WorkspaceGoal }>) {
const { t } = useWorkspaceI18n();
const agentLanes = useMemo(() => goal.agentLanes ?? (goal.agentId ? [{ agentId: goal.agentId, label: goal.agentLabel ?? goal.agentId }] : []), [goal]);
const [scope, setScope] = useState<Scope>("agent");
const [scope, setScope] = useState<"goal" | "agent">("agent");
const [agentId, setAgentId] = useState("");
const [automationOnly, setAutomationOnly] = useState(false);
const [automationId, setAutomationId] = useState("");
const [inspection, setInspection] = useState<AutomationCadence | null>(null);
const [minutes, setMinutes] = useState("0");
const [ownerReference, setOwnerReference] = useState("");
const [approveReduction, setApproveReduction] = useState(false);
const [preview, setPreview] = useState<AutomationCadence | null>(null);
const [busy, setBusy] = useState<"load" | "preview" | "apply" | null>(null);
const [busy, setBusy] = useState<"load" | "save" | null>(null);
const [error, setError] = useState<string | null>(null);
const [notice, setNotice] = useState<string | null>(null);
const [reloadSequence, setReloadSequence] = useState(0);
const [requiresRefresh, setRequiresRefresh] = useState(false);
const requestSequence = useRef(0);
const saving = useRef(false);
const scopedAgent = scope === "goal" ? null : agentId.trim() || null;
const scopedAutomation = scope === "automation" ? automationId.trim() || null : null;
const scopeReady = scope === "goal" || Boolean(scopedAgent && agentLanes.some((lane) => lane.agentId === scopedAgent) && (scope !== "automation" || scopedAutomation));
const scopedAutomation = scope === "agent" && automationOnly ? automationId.trim() || null : null;
const scopeReady = scope === "goal" || Boolean(scopedAgent && agentLanes.some((lane) => lane.agentId === scopedAgent) && (!automationOnly || scopedAutomation));

useEffect(() => {
if (!scopeReady) { setInspection(null); setPreview(null); setBusy(null); return; }
let active = true;
setBusy("load");
setError(null);
setPreview(null);
const sequence = ++requestSequence.current;
saving.current = false;
setInspection(null);
setNotice(null);
setError(null);
setRequiresRefresh(false);
if (!scopeReady) { setBusy(null); return; }
setBusy("load");
fetchAutomationCadence(goal.goalId, scopedAgent, scopedAutomation)
.then((result) => {
if (!active) return;
if (sequence !== requestSequence.current) return;
setInspection(result);
const direct = result.sources.find((source) => source.agent_id === scopedAgent && source.automation_id === scopedAutomation);
setMinutes(String(direct?.min_interval_minutes ?? result.min_interval_minutes));
setMinutes(String(direct?.min_interval_minutes ?? 0));
setOwnerReference("");
setApproveReduction(false);
})
.catch((reason: unknown) => { if (active) setError(reason instanceof Error ? reason.message : t("cadence.loadFailed")); })
.finally(() => { if (active) setBusy(null); });
return () => { active = false; };
}, [goal.goalId, scope, scopedAgent, scopedAutomation, scopeReady, reloadSequence, t]);
.catch((reason: unknown) => { if (sequence === requestSequence.current) setError(reason instanceof Error ? reason.message : t("cadence.loadFailed")); })
.finally(() => { if (sequence === requestSequence.current) setBusy(null); });
return () => { requestSequence.current += 1; };
}, [goal.goalId, scopedAgent, scopedAutomation, scopeReady, reloadSequence, t]);

const directRule = inspection?.sources.find((source) => source.agent_id === scopedAgent && source.automation_id === scopedAutomation);
const inheritedFloor = Math.max(0, ...(inspection?.sources.filter((source) => source !== directRule).map((source) => source.min_interval_minutes) ?? []));
const proposedMinutes = Number(minutes);
const validMinutes = /^\d+$/.test(minutes) && Number.isSafeInteger(proposedMinutes) && proposedMinutes <= 525600;
const reduction = validMinutes && directRule !== undefined && proposedMinutes < directRule.min_interval_minutes;
const canPreview = Boolean(inspection && scopeReady && validMinutes && ownerReference.trim() && (!reduction || approveReduction) && !busy);
const changed = proposedMinutes !== (directRule?.min_interval_minutes ?? 0);
const canSave = Boolean(inspection && scopeReady && validMinutes && changed && !requiresRefresh && !busy);

function invalidate() { setPreview(null); setNotice(null); setError(null); }
function edit() { setNotice(null); }

function change(): AutomationCadenceChange | null {
if (!inspection || !canPreview) return null;
return {
async function save() {
if (!inspection || !canSave || saving.current) return;
saving.current = true;
const sequence = requestSequence.current;
const reference = `App settings Save: ${directRule?.min_interval_minutes ?? 0} -> ${proposedMinutes} minutes (${scopedAutomation ? "automation" : scope})`;
const payload: AutomationCadenceChange = {
goal_id: goal.goalId, agent_id: scopedAgent, automation_id: scopedAutomation,
min_interval_minutes: proposedMinutes, expected_revision: inspection.configuration_revision,
owner_reference: ownerReference.trim(), approve_reduction: reduction && approveReduction,
owner_reference: ownerReference.trim() ? `${reference}. ${ownerReference.trim()}` : reference,
// The visible before/after value and explicit Save are the reduction intent.
approve_reduction: reduction,
};
}

async function createPreview() {
const payload = change();
if (!payload) return;
setBusy("preview"); setError(null);
try { setPreview(await previewAutomationCadence(payload)); }
catch (reason) { setError(reason instanceof Error ? reason.message : t("cadence.previewFailed")); }
finally { setBusy(null); }
}

async function apply() {
const payload = change();
if (!payload || !preview?.preview_revision) return;
setBusy("apply"); setError(null);
setBusy("save"); setError(null);
try {
const preview = await previewAutomationCadence(payload);
if (sequence !== requestSequence.current) return;
if (!preview.preview_revision) throw new Error(t("cadence.saveFailed"));
const result = await applyAutomationCadence(payload, preview.preview_revision);
if (sequence !== requestSequence.current) return;
setInspection(result);
setPreview(null);
const direct = result.sources.find((source) => source.agent_id === scopedAgent && source.automation_id === scopedAutomation);
setMinutes(String(direct?.min_interval_minutes ?? 0));
setOwnerReference("");
setApproveReduction(false);
setRequiresRefresh(!result.readback_verified);
setNotice(t(result.readback_verified ? "cadence.applied" : "cadence.readbackChanged"));
} catch (reason) {
setPreview(null);
setError(reason instanceof Error ? reason.message : t("cadence.applyFailed"));
} finally { setBusy(null); }
if (sequence !== requestSequence.current) return;
setRequiresRefresh(true);
setError(reason instanceof Error ? reason.message : t("cadence.saveFailed"));
} finally {
if (sequence === requestSequence.current) { saving.current = false; setBusy(null); }
}
}

return <section className="personal-cadence-settings" aria-label={t("cadence.title")}>
<div className="personal-cadence-intro">
<p>{t("cadence.description")}</p>
<form className="personal-cadence-form" onSubmit={(event) => { event.preventDefault(); void save(); }}>
<div className="personal-cadence-fields personal-cadence-target">
<label>{t("cadence.target")}<select aria-label={t("cadence.target")} disabled={Boolean(busy)} onChange={(event) => {
const lane = agentLanes.find((item) => `agent:${item.agentId}` === event.target.value);
setScope(event.target.value === "goal" ? "goal" : "agent");
setAgentId(lane?.agentId ?? ""); setAutomationOnly(false); setAutomationId(""); edit();
}} value={scope === "goal" ? "goal" : agentId ? `agent:${agentId}` : ""}>
<option value="">{t("cadence.chooseTarget")}</option>
<option value="goal">{t("cadence.scope.goal")} · {goal.title}</option>
<optgroup label={t("cadence.scope.agent")}>
{agentLanes.map((lane) => <option key={lane.agentId} value={`agent:${lane.agentId}`}>{lane.label === lane.agentId ? lane.agentId : `${lane.label} · ${lane.agentId}`}</option>)}
</optgroup>
</select>{agentLanes.length === 0 ? <small>{t("cadence.noAgents")}</small> : null}</label>
</div>
<fieldset className="personal-cadence-scopes">
<legend>{t("cadence.scope")}</legend>
{(["goal", "agent", "automation"] as const).map((option) =>
<label key={option}><input checked={scope === option} disabled={Boolean(busy)} onChange={() => { setScope(option); invalidate(); }} type="radio" name="cadence-scope" value={option} />{t(`cadence.scope.${option}`)}</label>)}
</fieldset>
{scope !== "goal" ? <div className="personal-cadence-fields">
<label>{t("cadence.agentId")}<select aria-label={t("cadence.agentId")} aria-describedby="cadence-agent-hint" disabled={Boolean(busy) || agentLanes.length === 0} onChange={(event) => { setAgentId(event.target.value); invalidate(); }} value={agentId}>
<option value="">{t(agentLanes.length ? "cadence.chooseAgent" : "cadence.noAgents")}</option>
{agentLanes.map((lane) => <option key={lane.agentId} value={lane.agentId}>{lane.label === lane.agentId ? lane.agentId : `${lane.label} · ${lane.agentId}`}</option>)}
</select><small id="cadence-agent-hint">{t("cadence.agentHint")}</small></label>
{scope === "automation" ? <label>{t("cadence.automationId")}<input disabled={Boolean(busy)} onChange={(event) => { setAutomationId(event.target.value); invalidate(); }} value={automationId} /></label> : null}
</div> : null}
{busy === "load" ? <p aria-live="polite">{t("common.loading")}</p> : null}
{inspection ? <>
<div className="personal-cadence-readback">
Expand All @@ -118,16 +118,21 @@ export function AutomationCadenceSettings({ goal }: Readonly<{ goal: WorkspaceGo
? t("cadence.directSource", { minutes: directRule.min_interval_minutes, inherited: inheritedFloor })
: scope === "goal" ? t("cadence.unconfigured") : t("cadence.inheritedSource", { minutes: inheritedFloor })}</p>
</div>
<p className="personal-cadence-boundary"><AlertTriangle aria-hidden size={16} />{t("cadence.boundary")}</p>
<div className="personal-cadence-fields">
<label>{t("cadence.minimum")}<input disabled={Boolean(busy)} min={0} max={525600} onChange={(event) => { setMinutes(event.target.value); invalidate(); }} type="number" value={minutes} /><small>{t("cadence.zeroHint")}</small></label>
<label>{t("cadence.ownerReference")}<input disabled={Boolean(busy)} maxLength={256} onChange={(event) => { setOwnerReference(event.target.value); invalidate(); }} value={ownerReference} /><small>{t("cadence.referenceHint")}</small></label>
<div className="personal-cadence-fields personal-cadence-target">
<label>{t("cadence.minimum")}<input aria-label={t("cadence.minimum")} disabled={Boolean(busy)} min={0} max={525600} onChange={(event) => { setMinutes(event.target.value); edit(); }} type="number" value={minutes} aria-invalid={!validMinutes} /><small>{t("cadence.zeroHint")}</small></label>
</div>
{reduction ? <label className="personal-cadence-reduction"><input checked={approveReduction} disabled={Boolean(busy)} onChange={(event) => { setApproveReduction(event.target.checked); invalidate(); }} type="checkbox" />{t("cadence.reduction")}</label> : null}
{preview ? <div className="personal-cadence-preview"><strong>{t("cadence.preview")}</strong><small>{goal.title} · {scopedAgent ?? t("cadence.scope.goal")}{scopedAutomation ? ` · ${scopedAutomation}` : ""}</small><span>{t("cadence.previewValue", { minutes: preview.min_interval_minutes })}</span><small>{t("cadence.previewLocked")}</small></div> : null}
<div className="personal-cadence-actions"><button disabled={!canPreview} onClick={() => void createPreview()} type="button">{t("cadence.preview")}</button><button className="is-primary" disabled={!preview || Boolean(busy)} onClick={() => void apply()} type="button">{t("cadence.apply")}</button></div>
{!validMinutes ? <p className="personal-machine-error" role="alert">{t("cadence.invalidMinutes")}</p> : null}
{validMinutes && changed ? <p className="personal-cadence-change">{t("cadence.change", { before: inspection.min_interval_minutes, after: Math.max(proposedMinutes, inheritedFloor) })}{proposedMinutes < inheritedFloor ? <small>{t("cadence.inheritedLimit", { minutes: inheritedFloor })}</small> : null}</p> : null}
</> : null}
{scope === "agent" && scopedAgent ? <details className="personal-cadence-details"><summary>{t("cadence.automationSettings")}</summary><label className="personal-cadence-automation"><input checked={automationOnly} disabled={Boolean(busy)} onChange={(event) => { setAutomationOnly(event.target.checked); edit(); }} type="checkbox" />{t("cadence.automationOnly")}</label>{automationOnly ? <div className="personal-cadence-fields"><label>{t("cadence.automationId")}<input aria-label={t("cadence.automationId")} disabled={Boolean(busy)} maxLength={256} onChange={(event) => { setAutomationId(event.target.value); edit(); }} value={automationId} /></label></div> : null}</details> : null}
{inspection ? <>
<details className="personal-cadence-details"><summary>{t("cadence.ownerReference")}</summary><div className="personal-cadence-fields"><label>{t("cadence.note")}<input aria-label={t("cadence.note")} disabled={Boolean(busy)} maxLength={160} onChange={(event) => { setOwnerReference(event.target.value); edit(); }} value={ownerReference} /><small>{t("cadence.referenceHint")}</small></label></div></details>
<p className="personal-cadence-boundary">{t("cadence.boundary")}</p>
<div className="personal-cadence-actions"><button className="is-primary" disabled={!canSave} type="submit">{t(busy === "save" ? "cadence.saving" : reduction ? "cadence.saveReduction" : "cadence.save")}</button></div>
</> : null}
{error ? <p className="personal-machine-error" role="alert">{error} <button onClick={() => { invalidate(); setReloadSequence((value) => value + 1); }} type="button"><RefreshCw aria-hidden size={14} />{t("cadence.retry")}</button></p> : null}
{notice ? <p aria-live="polite" className="personal-cadence-notice">{notice}</p> : null}
{error ? <p className="personal-machine-error" role="alert">{error}</p> : null}
{notice ? <p aria-live="polite" className={requiresRefresh ? "personal-cadence-boundary" : "personal-cadence-notice"}>{requiresRefresh ? <AlertTriangle aria-hidden size={16} /> : null}{notice}</p> : null}
{error || requiresRefresh ? <button disabled={Boolean(busy)} onClick={() => setReloadSequence((value) => value + 1)} type="button"><RefreshCw aria-hidden size={14} />{t("cadence.retry")}</button> : null}
</form>
</section>;
}
Loading
Loading