Skip to content

fix(dashboard): keep clickable execution chip compact - #5345

Open
Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/fix-clickable-execution-chip-height
Open

Duang777 wants to merge 1 commit into
loopx-project:mainfrom
Duang777:codex/fix-clickable-execution-chip-height

Conversation

@Duang777

Copy link
Copy Markdown
Collaborator

Problem

PR #5341 changed the execution chip from a span to a button and gave the desktop button a 28px minimum height. The packaged browser smoke still enforces the existing 26px compact-row contract, so current main fails with Execution chip is not a compact hairline row: 28px tall.

Main failure evidence: https://github.com/loopx-project/loopx/actions/runs/36691337881/job/109809017646

Change

Verification

  • npm run build
  • LOOPX_PERSONAL_WORKSPACE_SCENARIO=execution-chip npm run smoke:personal-workspace-packaged
  • python scripts/chat_bundle.py verify --source
  • git diff --check

The packaged browser scenario passed on top of main@7e60e6999, including the 26px desktop assertion and 390px mobile viewport checks.

Signed-off-by: duanjialing.777 <duanjialing.777@bytedance.com>
@Duang777

Copy link
Copy Markdown
Collaborator Author

Exact-head CI is green on c33543eaae57f33e28c82f0c85be27216bbe785b (20 passing checks, no failures or pending jobs).

The checks include Frontstage Pages, Release Artifacts, macOS and Windows desktop builds, dashboard-acceptance, chat-bundle-browser, all three TypeScript shards, TypeScript coverage, and merge-gate. This independently clears the repeated Execution chip is not a compact hairline row: 28px tall baseline failure seen on #5338 and #5344. The mobile 44px rule remains unchanged.

Ready for maintainer review; no merge action was taken.

@Duang777

Copy link
Copy Markdown
Collaborator Author

@huangruiteng @maxliux5 This exact head remains fully green and is now the dependency blocking #5344 from resolving its main conflict without retaining the old execution-chip baseline failure. Please review when available. No merge action has been taken.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant