Skip to content

Added max error criterion in addition to RMS error criterion. - #198

Open
craiglagegit wants to merge 3 commits into
mainfrom
tickets/DM-56137
Open

craiglagegit wants to merge 3 commits into
mainfrom
tickets/DM-56137

Conversation

@craiglagegit

Copy link
Copy Markdown
Contributor

I set the RMS criterion back to 10 arcsec, and added a max linear Error criterion that is also 10 arcsec. This now catches image 2025071800381, which passed before. We will need to run more to see if this generates a buch of false positives.
Mount_Plot_Hex_2025071800381 (1)

@craiglagegit

Copy link
Copy Markdown
Contributor Author

When I ran many plots, there were a lot of false positives. The problem is that sometimes the azimuth telemetry timestamps are not equally spaced. See the attached two plots, one where all timestamps are 50msec apart and one where they have variable spacing. This was not the case before a few months ago, and I suspect it has to do with the toolbelt incident. The linear model assumed that the timestamps were equally spaced. So I've updated the linear model to calculate the points at the same times as the timestamps. This should fix the problem. I'll have Claude run a bunch more test cases and see if that fixes the false positives.
Also attached are plots before and after the fix. This will allow us to go back to the 10 arcsecond threshold.
Timestamp_Deltas_2026060300359
Timestamp_Deltas_2026060300300
Mount_Plot_Hex_Fix_2026052800633
Mount_Plot_Hex_2026052800633

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

mypy-coverage report

✅ All 810 definitions are fully annotated.

  • Root: /home/runner/work/summit_utils/summit_utils
  • Config: mypy.ini
  • Files scanned: 60
  • Files excluded: 0

Summary

metric value
✅ body-checked by mypy 100.0%
✅ fully annotated 100.0%
annotated 810
partial 0
unannotated 0

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.55%. Comparing base (9594f2b) to head (da5afb7).

Files with missing lines Patch % Lines
python/lsst/summit/utils/simonyi/mountAnalysis.py 0.00% 43 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
- Coverage   23.64%   23.55%   -0.09%     
==========================================
  Files          38       38              
  Lines        7155     7182      +27     
==========================================
  Hits         1692     1692              
- Misses       5463     5490      +27     
Files with missing lines Coverage Δ
python/lsst/summit/utils/simonyi/mountAnalysis.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant