Added max error criterion in addition to RMS error criterion. - #198
Open
craiglagegit wants to merge 3 commits into
Open
craiglagegit wants to merge 3 commits into
craiglagegit wants to merge 3 commits into
Conversation
Contributor
Author
mypy-coverage report✅ All 810 definitions are fully annotated.
Summary
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #198 +/- ##
==========================================
- Coverage 23.64% 23.55% -0.09%
==========================================
Files 38 38
Lines 7155 7182 +27
==========================================
Hits 1692 1692
- Misses 5463 5490 +27
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




I set the RMS criterion back to 10 arcsec, and added a max linear Error criterion that is also 10 arcsec. This now catches image 2025071800381, which passed before. We will need to run more to see if this generates a buch of false positives.
