[nunnsy]

Problem

executor.MakeExec on darwin returns *steam.Exec, but NativeMacOsGame asserted the value type steam.Exec, so it always returned false for native Steam AoE2 on Apple Silicon.

Effect

GamePathToGameCertPath skipped the AgeOfEmpires2Data mapping and the launcher looked for:

.../steamapps/common/AoE2DE/certificates/cacert.pem

instead of:

.../steamapps/common/AoE2DE/AgeOfEmpires2Data/certificates/cacert.pem

aborting after Adding CA certificate to game. It also affected the BattleServerRequired / macOsExclusiveMappings decisions.

Fix

- if _, ok := executer.(steam.Exec); ok {
+ if _, ok := executer.(*steam.Exec); ok {

Verification

Rebuilt with task build and ran dist/launcher_mac_darwin_arm64_v8.0/launcher -e age2: the launcher now proceeds past the CA step and launches the game against a LAN server.

[nunnsy]

If we could also get a release off the back of this too, would be much appreciated. Cheers!

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[luskaner]

Thanks, merged will do a bug release! ;)

[nunnsy]

Tyvm - this is fantastic showing the crossplay between Windows and Mac is indeed possible. Have been testing it out running a persisting BattleServer with Wine on a Ubuntu server (as documented here), with clients connecting using this launcher. Many thanks for your work here!

[luskaner]

@nunnsy wait... you mean the native apple silicon aoe2 macos version can play with linux/windows?! or you mean the emulated one in macos?

[nunnsy]

@luskaner I was running the native Apple Silicone yes. I need to double check Windows will be happy connecting to the same external BattleServer running under WINE on a separate Ubuntu host, as I wasn't 100% pleased with my own test when I ran it (no tech glitch, just doing it via a CrossOver engine, would rather run it on a Windows box itself).

[luskaner]

@nunnsy It was supposed (from the community side) that they disabled crossplay because of the differences between Apple Silicon and X86 hardware on Windows that inevitably would cause desyncs, If you are 100% sure, I encourage you to make a reddit post or something about it ;)

PS: While macOS misses having a native port of the battle server, that should be no problem as the actual game simulation is done on the clients themselves

[nunnsy]

@luskaner yeah that was my understanding too, though I'm genuinely curious about the desync if this is all over IP anyway.

I plan to test next weekend and will let you know of the result either way with a longer-running, Windows native instance on the other side 👍

[luskaner]

@nunnsy alright, yeah a long running match with multiple players (if possible) should a good test to be sure.

PS: 1.15.6 released, enjoy ;)

[nunnsy]

It desync'd almost immediately, I was wrong :'(

[luskaner]

It desync'd almost immediately, I was wrong :'(

Sadly... as expected :( fortunately it should run well through Crossover, etc

[nunnsy]

yeah here's hoping, an old patch broke it running efficiently but watching that space closely!! other than that the local persistent battle server runs very well