Repository navigation
Let the local runner rent while a peer is asleep - #68
Conversation
#67 put the local supplier's probe under the candidates' deadline, but it still ran after them, so whenever a peer hung until the deadline the local runner got no time and --where could not rent while any peer was asleep. Suppliers are now probed in the same call as the candidates, first so the fan-out limit never holds them back, and their answers are used only when renting. The bare wildcard skips them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013BQxiCNDXMnjv5pvmgo5E6
|
@codex review @codex security review Generated by Claude Code |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 112ef4909b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Suppliers shared the candidates' fan-out slots, so enough hung peers could still keep the local runner from being asked, and a hung local runner delayed every placement until the deadline, even when one of your runners matched at once. Suppliers now get their own probe call, started with the candidates under the same deadline, and are awaited only when renting; otherwise the deadline's cancel ends them. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013BQxiCNDXMnjv5pvmgo5E6
|
@codex review Generated by Claude Code |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
@codex security review Generated by Claude Code |
|
You have reached your Codex usage limits for security reviews. Please try again later. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Before: since #67,
--where gpuon a laptop whose runner has cloud offers fails whenever one of your peers is asleep:no runner matches "gpu": asleep: context deadline exceeded; local: probe deadline exceeded. The peer's probe uses the whole 2 s deadline, and the local runner is asked only after it, so it gets no time.After: the laptop rents even with sleeping peers, a hung local runner never delays a runner of yours that matches, and selection still takes at most about 2 s.
How:
chooseRunnerssets one 2 s deadline. Lease suppliers (the runner installed here) are probed in their ownprobeCandidatescall, started at the same time as the candidates, so hung peers can't use up their time or their probe slots. Their answers are awaited only when renting is needed. Otherwise the deadline's cancel ends them, and they are never a job target.--where '*', which never rents, skips them. The cost is one local socket probe running in parallel, only for users whose installed runner has cloud offers.Tests:
TestSupplierProbeSharesSelectionDeadlinecovers four cases:TestLocalCloudPeerOnlySuppliesLeaseschecks that the local runner is never chosen.go test -race ./cmd/errand/ ./internal/config/(and-count=3on the placement tests) andgo vetpass.🤖 Generated with Claude Code
https://claude.ai/code/session_013BQxiCNDXMnjv5pvmgo5E6