chore: dedupe Maven Central Sonatype credentials in release-publish#740
Merged
Conversation
The rokt-sdk-plus publish step referenced ROKT_SONATYPE_NEXUS_* while the core/kits steps use SONATYPE_NEXUS_*. Both point at the same Sonatype account (which owns both the com.mparticle and com.rokt namespaces), so the duplicate pair is unnecessary. Point the rokt-sdk-plus step at the shared SONATYPE_NEXUS_* credentials. The Rokt signing key is intentionally kept distinct for com.rokt provenance.
PR SummaryCursor Bugbot is generating a summary for commit 5713b85. Configure here. |
|
thomson-t
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The release-publish workflow carried two pairs of Sonatype credentials for Maven Central:
SONATYPE_NEXUS_USERNAME/SONATYPE_NEXUS_PASSWORD— used by the core + kits publish steps (com.mparticle).ROKT_SONATYPE_NEXUS_USERNAME/ROKT_SONATYPE_NEXUS_PASSWORD— used only by therokt-sdk-pluspublish step (com.rokt).Both pairs resolve to the same Sonatype account, which owns both the
com.mparticleandcom.roktnamespaces, so theROKT_-prefixed pair is redundant.What changed
Publish rokt-sdk-plus to Maven Centralstep now reads the sharedSONATYPE_NEXUS_USERNAME/SONATYPE_NEXUS_PASSWORDsecrets instead of theROKT_-prefixed duplicates.ROKT_MAVEN_CENTRAL_SIGNING_KEY/..._PASSWORD) is intentionally left in place — it is a distinct key kept forcom.roktartifact provenance, not a duplicate.ROKT_SONATYPE_NEXUS_*are now unreferenced and can be deleted separately if desired.Test plan
VERSIONchange onmain) publishescom.mparticle:*andcom.rokt:rokt-sdk-plusto Maven Central with the shared Sonatype credentials.