You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(jsonrpc): keep id as null in error responses - #1880
When the request id can't be read, for example on a malformed body over HTTP or WebSocket, the error response leaves out id entirely because ResponseErrorPayload skips it when it is None. JSON-RPC 2.0 requires id on every response and says it must be null in that case, and Agave sends "id":null. The fallback body in server/http/dispatch.rs already does this, so only the normal path disagreed.
Dropping the skip_serializing_if makes None serialize as null; responses with a known id are unchanged. Added test_parse_error_response_has_null_id in aperture/tests/batches.rs, which posts { and checks the response has "id": null.
Reviewing files that changed from the base of the PR and between 1e88ac3 and 0a86716.
Files selected for processing: 1
aperture/src/requests/payload.rs
No actionable comments were generated in the recent review.
Walkthrough
Error response payloads now serialize an absent request ID as null instead of omitting the field. Tests check responses with absent and numeric request IDs.
The change addresses null-ID error responses and preserves known IDs.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: preserving a JSON-RPC error response id as null.
Description check
The description directly explains the id serialization issue, the JSON-RPC requirement, the implementation change, and the added test.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 0f21b78 and 1e88ac3.
Files selected for processing: 1
aperture/src/requests/payload.rs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bmuddha
left a comment
When the request id can't be read, for example on a malformed body over HTTP or WebSocket, the error response leaves out
identirely becauseResponseErrorPayloadskips it when it isNone. JSON-RPC 2.0 requiresidon every response and says it must benullin that case, and Agave sends"id":null. The fallback body inserver/http/dispatch.rsalready does this, so only the normal path disagreed.Dropping the
skip_serializing_ifmakesNoneserialize asnull; responses with a known id are unchanged. Addedtest_parse_error_response_has_null_idinaperture/tests/batches.rs, which posts{and checks the response has"id": null.