Repository navigation
page-chat 0.1.5: README - document the settings.json gateway port - #542
Merged
Merged
Conversation
The "What the service reads and sends" section still described the gateway order as MAGPIE_CHAT_GATEWAY -> MAGPIE_ADDR -> 3425, and still said settings.json is only read for fonts. 0.1.4 added a step in between: the port from magpie's settings.json (the portable build writes its real port there). Mention it in both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #534 (merged as
20a3898).The "What the service reads and sends" section in the README still said the gateway is picked
as
MAGPIE_CHAT_GATEWAY→MAGPIE_ADDR→http://127.0.0.1:3425, and thatsettings.jsonisonly read for fonts. 0.1.4 added a step in between: the
portfrom magpie'ssettings.json(the portable build writes its real port there, e.g.
18086).Only README and the version number change; no code.