Fix: Escape parentheses in markdown link URLs from DOCX conversion#33
Open
oxygen-dioxide wants to merge 1 commit into
Open
Fix: Escape parentheses in markdown link URLs from DOCX conversion#33oxygen-dioxide wants to merge 1 commit into
oxygen-dioxide wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When converting DOCX files to Markdown, hyperlinks containing parentheses in their URLs produce broken markdown. For example, a link to
https://en.wikipedia.org/wiki/Mole_(unit)would generate:The unescaped
)prematurely terminates the markdown link syntax[text](url), resulting in malformed output.Fix
Added percent-encoding for parentheses in the target URL within
MarkdownStringWriter.WriteHyperlink(src/DocSharp.Common/Writers/MarkdownStringWriter.cs:117):(→%28)→%29#32 is fixed.