Skip to content

Point the repository URL at mapbox/mapbox-cli - #102

Merged
zmofei merged 1 commit into
report-commandfrom
fix-repo-url
Oct 19, 2026
Merged

zmofei merged 1 commit into
report-commandfrom
fix-repo-url

Conversation

@zmofei

@zmofei zmofei commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

The repository URL in the crate (repo_url!, which REPO_URL uses) and Cargo.toml's repository still named github.com/mapbox/cli, which redirects to a private repo. Links built from it, the issues link in account_usage's error and report's docs link from #100, are a 404 for anyone outside Mapbox. The installers already name mapbox/mapbox-cli. Stacked on #100.

Both now name https://github.com/mapbox/mapbox-cli, and a new source guard holds repo_url! and both installers to Cargo.toml's repository.

Testing: the full suite passes; with the old URL put back in repo_url!, the new guard fails.

@zmofei
zmofei requested a review from a team as a code owner October 19, 2026 16:41
@zmofei
zmofei changed the base branch from main to report-command October 19, 2026 16:42
@zmofei
zmofei added this pull request to stack #101 October 19, 2026 16:42
REPO_URL and Cargo.toml still named github.com/mapbox/cli, which redirects to a private repo, so the issues link in account_usage's error was a 404 for anyone outside. The installers already name mapbox/mapbox-cli. A source guard now holds all four copies to Cargo.toml's repository.
mattpodwysocki
mattpodwysocki previously approved these changes Oct 19, 2026

@mattpodwysocki mattpodwysocki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and good call on the guard test.

@zmofei
zmofei dismissed mattpodwysocki’s stale review October 19, 2026 17:48

The merge-base changed after approval.

@zmofei
zmofei merged commit 4c8dd09 into main Oct 19, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants