Repository navigation
Fix the Completion widget in the Review workspace - #2927
Open
CollinBeczak wants to merge 1 commit into
Open
CollinBeczak wants to merge 1 commit into
CollinBeczak wants to merge 1 commit into
Conversation
Point the reviewer completion action at the new backend endpoint (PUT /task/:id/completionStatus/:status) rather than the review-status endpoint. That call preserved the review status but still went through the mapper's status-change path, which rejected the reviewer outright. The task it returns is dispatched so the pane reflects the new status without a refetch, and the reviewer's comment is posted separately - it previously rode along on the review call and is dropped by the new endpoint. The widget also could not be removed from the Review workspace: it hardcoded `permanent` on its QuickWidget, suppressing Delete Widget everywhere rather than only where the workspace declares it permanent. Reviewers can now remove and re-add it; the task pane is unaffected, since only ReviewTaskPane sets asReviewer. Let reviewers edit the bundle of the task they're reviewing. Bundle edits were disabled in the Review workspace three ways - the workspace allowlist, the done-or-review gate (a task under review is complete by definition, so this always tripped) and the mapper-edits check. All three are mapper-flow rules. The read-only, locked and cooperative/tag-fix gates still apply.
CollinBeczak
marked this pull request as ready for review
September 30, 2026 19:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point the reviewer completion action at the new backend endpoint (PUT /task/:id/completionStatus/:status) rather than the review-status endpoint. That call preserved the review status but still went through the mapper's status-change path, which rejected the reviewer outright. The task it returns is dispatched so the pane reflects the new status without a refetch, and the reviewer's comment is posted separately - it previously rode along on the review call and is dropped by the new endpoint.
The widget also could not be removed from the Review workspace: it hardcoded
permanenton its QuickWidget, suppressing Delete Widget everywhere rather than only where the workspace declares it permanent. Reviewers can now remove and re-add it; the task pane is unaffected, since only ReviewTaskPane sets asReviewer.Let reviewers edit the bundle of the task they're reviewing. Bundle edits were disabled in the Review workspace three ways - the workspace allowlist, the done-or-review gate (a task under review is complete by definition, so this always tripped) and the mapper-edits check. All three are mapper-flow rules. The read-only, locked and cooperative/tag-fix gates still apply.