Repository navigation
Pick Dmin/Dmax by hand; move Film Base to Readouts - #1592
Merged
Merged
Conversation
Pick by Hand fold in the Metering card: Dmin (thinnest spot) and Dmax (densest spot) each replace one end of the frame's bounds, per channel. The picks route through resolve_bounds_detailed, so CPU and GPU share them; roll Use Average still wins. The canvas shows labelled marks while a pick tool is armed. Luma and color clip gray out when both ends are picked. Film Base moves to an icon toggle on the Analysis Readouts header, next to the numbers it changes, with a dot and a clear button. Reanalyze Frame moves down beside Draw Region; Lock stays on the ANALYSIS header. header_actions() puts sub-header buttons at a fixed share of the row and is used for the short-label rows across the panels. Sub-headers and fold headers use body size and text_secondary. Roll Analysis loses its darker body box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_bounds_detailed, so the CPU and the GPU use the same values. The GPU analysis key includes the picks.manual_*_at) are used only for the canvas marks. They are in_UNHASHED_FIELDS.None, so there is noBOUNDS_VERSIONorTHUMBNAIL_RENDER_VERSIONbump.header_actions()factory: puts labeled buttons on a sub-header row at a fixed share of the width. It is used for the short-label header rows (Metering, Roll Analysis, Scenes, Retouch, Flat Field, Scanlight exposure, Export color management, Gear Library).section_subheaderand fold headers) use body size andtext_secondary.Test plan
make all: lint, type check and Rust checks pass. The full pytest run had 1 failure, the Tools menu test that expected no "Analysis" group. After I updated the test, that one test passes. I did not run the full suite again.tests/test_manual_bounds_pick.py(bounds resolution, controller pick and clear, CPU/GPU parity),tests/test_header_actions.py, and a Readouts-header test intests/test_film_base.py.