Repository navigation
Fade Restoration: Gray Range Estimate sets Red Survival - #1594
Open
thetalkingdrum wants to merge 1 commit into
Open
thetalkingdrum wants to merge 1 commit into
thetalkingdrum wants to merge 1 commit into
Conversation
Gray Range left Red Survival as it was, so on a badly faded slide it set green and blue survivals near 5 with red at 1.0 and blew the frame out. Both methods now set Red Survival to 1/max(green, blue, 1), so the best-kept layer keeps its density. A mild fade with both ratios at or below 1 keeps Red Survival at 1.0.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a badly faded slide, the Gray Range Estimate set Green and Blue Survival near 5 but left Red Survival at 1.0. This divided the green and blue density by about 5 and 3.4, and the frame blew out. Both Estimate methods now set Red Survival as Midtone does, to 1/max(green, blue, 1), so the best-kept layer keeps its density. A mild fade with both ratios at or below 1 keeps Red Survival at 1.0.
On
49482616516_173356cdb6_o.jpg, a red-cast DOCUMERICA JPEG set to Slide and Positive, Gray Range wrote r 1.00, g 5.00, b 3.36. The mean green and blue went to 0.76 and 0.77, and 1.3% of the pixels clipped. With this change it writes r 0.20, g 5.00, b 3.36, and no pixels clip. Renders for unchanged settings do not change, soTHUMBNAIL_RENDER_VERSIONandBOUNDS_VERSIONstay the same. This change is separate from #1591, which is merged and only changes when Remove Stain is suggested.