Disambiguate whitespace-preceded ">" in HTML attributes - #234
Conversation
🦋 Changeset detectedLatest commit: 2e5d2d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 12 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (24)
📒 Files selected for processing (31)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
========================================
Coverage 99.95% 99.95%
========================================
Files 34 34
Lines 4270 4466 +196
Branches 793 853 +60
========================================
+ Hits 4268 4464 +196
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
42b2e1e to
6c0c436
Compare
In HTML mode a
>after an unenclosed attribute always closed the tag, so<if=count > 10>silently parsed as<if=count>followed by the text10>— a chronic trap since both readings are valid. The parser now looks ahead when an attribute ends at whitespace followed by>: if the rest of the line has the shape of a split comparison ending in a>that hugs its final operand (10>,x.length>,10 && flag/>), it reports an error telling the author to either parenthesize the expression or remove the whitespace before the tag-closing>. Anything the look-ahead does not recognize keeps the existing behavior, so ordinary content like<div class=foo > Hello</div>is unaffected.Whitespace-preceded
>=is now parsed as a comparison operator (matching<=), since a tag close can never be followed by a hugging=.Additionally, a whitespace-preceded
</after an unenclosed attribute value is now treated as a close tag instead of being consumed as a less-than operand (previously<div class=x + y </div>swallowed the close tag into the value and reported a misleadingMissing ending "div" tag); a close tag found before the open tag is completed now reports a targeted error suggesting parentheses. Genuine less-than comparisons (a < b,a < /re/.test(c)) are unaffected.