Pbem4wass - #60
Open
andreamola wants to merge 68 commits into
Open
Conversation
…scellaneous cleaning
…ct solve; missing output and error facilities
…ripts to compare .vtus; discovered that multiprocess MPI runs have a const difference from reference solutions, but only in phi: gradients are fine, as well as alphas
…n local expansion, gave good gains
…tors and copy semantics for OctreeBlock
…nation; more precise loops on dofs for fma traversals
…st flat_set; used distance_square; some more use of leaner constructors
…f BlockVector and Vector of norms of components; used to guide global refinement
…ipts/indent moved an include, but much more confusing changes were done in bem_fma
…ent at one of the corners of the coarse sphere
…shifting vectors when phi is constrained; solved test problems with complex robin coefficients
… was transformed to specify the position of the manifold's function; this allows multiple b.conditions of the same type
…ple computations where possible
…xplicit copies to temporary structs
…re versatile calls
…arily disabled complex preconditioner parallelized in OpenMP
… threads due to vectorization
…th showcases on cube2sphere with cad refinement and real, complex formulations on all combinations of boundary conditions
Contributor
Author
|
I think the indent script in the scripts folder is not the same that is run in the checks. How can I get the same script also in pi-BEM? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains all the changes Lorenzo Fabris put together in his HPC thesis.
In particular:
I am sorry this wealth of work comes only in a single PR, but to get this to work I already had to recover this version from Lorenzo, fix compilation and execution errors on current compilers, slip his 60+ commits past the 24 or so that had been done in pi-BEM while he was working. So it took a huge rebase and a lot of conflict fixing. Let me know if you guys think things look good.
In the meantime, this version is currently working with no issues in new projects we are working on, in which the complex formulation and Robin conditions are needed. In addition, all tests pass.