Skip to content

Fix first RTX capture and simplify color output aliases - #5

Merged
matthewtrepte merged 1 commit into
matthewtrepte:mtrepte/newton-rtx-markers-and-ldrcolor-fixfrom
ooctipus:octi/newton-rtx-first-capture-cleanup
Oct 2, 2026
Merged

matthewtrepte merged 1 commit into
matthewtrepte:mtrepte/newton-rtx-markers-and-ldrcolor-fixfrom
ooctipus:octi/newton-rtx-first-capture-cleanup

Conversation

@ooctipus

@ooctipus ooctipus commented Oct 1, 2026

Copy link
Copy Markdown

Description

Follow-up to isaac-sim#8220, targeting mtrepte/newton-rtx-markers-and-ldrcolor-fix.

The first asynchronous RTX capture fetched its pending result directly and bypassed the color-output alias setter, raising save_screenshot() could not find the LdrColor render output. It now stores that result through the existing normalization path before Newton reads the pixels.

Color aliases are resolved from the returned keys. This removes the duplicated package-version detector, its cache, and its metadata tests while preserving existing short-name outputs. The existing RTX integration test now checks the first capture before warm-up can suppress its error.

Type of change

  • Bug fix

Validation

  • The extended RTX integration test failed on the target branch with the missing-color error and passed with the fix (Newton dff296359, OVRTX 0.5.0.377615).
  • All 72 adapter tests passed, including full-path, short-name, and mixed-key outputs.
  • uv run isaaclab -f and the changelog check against the target branch passed.

Checklist

  • Read the contribution guidelines.
  • Ran the repository formatting and lint checks.
  • Extended existing coverage and verified the regression failed before the fix.
  • Added a changelog fragment for the affected package.
  • Contributor is already listed in CONTRIBUTORS.md.

@matthewtrepte
matthewtrepte merged commit c03c0a3 into matthewtrepte:mtrepte/newton-rtx-markers-and-ldrcolor-fix Oct 2, 2026
1 check passed
@ooctipus
ooctipus deleted the octi/newton-rtx-first-capture-cleanup branch October 14, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants