Repository navigation
Clear the Ruff findings super-linter 9.0.0 reports - #185
Merged
Merged
Conversation
The Ruff in the super-linter 9.0.0 image, which the "Lint teams-copy with Ruff" CI step runs once PR #184's bump lands, reports RUF007 on join_with_spacers: it walks successive blocks with zip(blocks, blocks[1:]). The step fails on that finding before super-linter's own step is reached. itertools.pairwise yields the same pairs without building the sliced copy. It needs Python 3.10, and teams-copy runs on Homebrew's python3.
super-linter 9.0.0, which PR #184 bumps to, runs Ruff 0.16.8 across the codebase, and its PYTHON_RUFF check reports three findings in unfilled-blocks.py: a closing-fence pattern built with % formatting (UP031), two endswith calls on one string (PIE810) and successive block lines walked with zip(block, block[1:]) (RUF007). The fence pattern is now an f-string, the endswith calls take one tuple and the walk uses itertools.pairwise, which needs Python 3.10. Each produces the same result, and the detector's test cases still pass.
mattmenefee
changed the title
mattmenefee
marked this pull request as ready for review
October 24, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
home/.local/bin/teams-copy:join_with_spacerswalks successive blocks withitertools.pairwiseinstead ofzip(blocks, blocks[1:])(RUF007), which failed the "Lint teams-copy with Ruff" step on Bump super-linter/super-linter from 8.7.0 to 9.0.0 in the github-actions group #184 before super-linter's own step ranhome/.claude/skills/reflow/scripts/unfilled-blocks.py: super-linter 9.0.0's PYTHON_RUFF check (Ruff 0.16.8) reports three findings once that step passes; the closing-fence pattern is an f-string (UP031), twoendswithcalls take one tuple (PIE810) and the block walk usesitertools.pairwise(RUF007)itertools.pairwiseneeds Python 3.10. Both scripts run locally on Homebrew'spython3, and CI's "Test teams-copy's Markdown to HTML conversion" and "Test the /reflow block detector" steps passed on thepairwisecode in Bump super-linter/super-linter from 8.7.0 to 9.0.0 in the github-actions group #184's run..ruff.toml's selection (UP, PIE, RUF) is not confirmed: the image could not be pulled locallyTest plan
bash test/test-teams-copy.sh: 30 cases passed, on Homebrew Python 3.15.0bash home/.claude/skills/reflow/scripts/test-unfilled-blocks.sh: 38 cases passed%form (checked in Python for a three-character fence)lintpasses on this pull request (super-linter 8.7.0; run 40133478046 on 4497da7)lintwith super-linter 9.0.0, PYTHON_RUFF included (run 40132458694 on 81bbba4)