Repository navigation
Fix private thumbnail previews and expose paginated storage listing - #21
Merged
Merged
Conversation
davidvanleeuwen
marked this pull request as ready for review
October 20, 2026 18:27
davidvanleeuwen
deleted the
fix/private-thumbnails-and-storage-listing
branch
October 20, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Private embeds with an uploaded poster use the public poster URL in dashboard detail and upload previews, so the image cannot load once storage access becomes private. Use the existing signed thumbnail URL for those previews, keeping its cache-buster inside the signature and temporary URLs out of copyable embed code.
Expose the existing paginated storage-prefix listing as
Storage.list_keys/3so consumers can enumerate actual stored objects, including historical versions.Validation: regression coverage for private player/upload previews, signed cache parameters, preserved public URLs, and two-page object listings. The combined candidate passed 1,247 Core tests and 466 downstream tests, strict Credo, security enforcement, formatting, and compilation with warnings as errors. GitHub CI is pending before this draft is marked ready.