Repository navigation
Fix legacy HLS paths when refreshing media playlists - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing a playlist after audio or subtitle changes could treat an imported database identifier as an object-storage path. That produced HLS references to nonexistent objects even though the media files were still present.
Resolve legacy rendition and subtitle identifiers to version-scoped media paths. For legacy media, retain existing separate audio tracks and omit missing ones only when every video variant contains muxed audio. Otherwise leave the current playlist intact. Invalidate the refreshed master playlist. Modern custom rendition paths remain unchanged.
Validation: Core test suite, six focused HLS regression tests (including replacement versions and storage failures), strict Credo, and the existing security checks.